From owner-freebsd-hackers@FreeBSD.ORG Sat Aug 24 22:04:08 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 362FFD88 for ; Sat, 24 Aug 2013 22:04:08 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pd0-x231.google.com (mail-pd0-x231.google.com [IPv6:2607:f8b0:400e:c02::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0C1E8267A for ; Sat, 24 Aug 2013 22:04:08 +0000 (UTC) Received: by mail-pd0-f177.google.com with SMTP id y10so1987503pdj.8 for ; Sat, 24 Aug 2013 15:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=yVEohdlTpURb5GgFk8Zml+wDFVs+l7ond/SvgsMYr3I=; b=S0QH1zUak5SzQs8FYLfB902XMz0kPPKPX3eUoQAdZGlbWBzwFbUjHExGwvVPVIHWBp CKsbipMMwVKIHAlfmjxOQGxpGtrw+07XxPd09WbRuJGvaSb1IlJhQETP0Nwhjc20n6Sf gHdiu4DkmsFcw+ynjSNnwyn4uOL3oml/ri5ec= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=yVEohdlTpURb5GgFk8Zml+wDFVs+l7ond/SvgsMYr3I=; b=YUeBjDNhUGaphgP9ZKuK2hwhPiiIHP/zdInLkx3cNiAthV4YHsoFUnNt5ARvMzpPNb M/MSbYEmtktHG8ok0RtKqouhr1gh2dwNiyPT6Z5QjKFSrFbRmXhqL784jBC2lquKB8pZ moljf0AzleklRwK5hQ9MdzcQrJklJWK5dwlJgJMY0IZl3UbsBmNMW+IfhiqOZyJGDd5S s9MowqcoTc2EHD7t63qeQNr/3xOfIeQoTdvzj8xuB6zKPM3t+mkDSmCb7xDLIfuYk4Vm nsWWpR+p7ndrMhP/9bX5uV3KmJ4GLHejojsPR8B3pte3bDS5UPVOKs8ZEY1QDCX/1DN8 3wGQ== X-Gm-Message-State: ALoCoQnwQYXuENzQDaUgYNZlvfg8jd04TpUvZM95QqhSte9NO622AIyLAfF1esBpOyFjAPZ7q74x X-Received: by 10.66.190.198 with SMTP id gs6mr6136748pac.49.1377381847666; Sat, 24 Aug 2013 15:04:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.70.6.3 with HTTP; Sat, 24 Aug 2013 15:03:37 -0700 (PDT) In-Reply-To: <20130824204725.GF24767@caravan.chchile.org> References: <20130822204958.GC24767@caravan.chchile.org> <20130824204725.GF24767@caravan.chchile.org> From: Eitan Adler Date: Sat, 24 Aug 2013 18:03:37 -0400 Message-ID: Subject: Re: weekly periodic security status To: Eitan Adler , FreeBSD Hackers Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2013 22:04:08 -0000 On Sat, Aug 24, 2013 at 4:47 PM, Jeremie Le Hen wrote: > On Sat, Aug 24, 2013 at 10:41:56AM -0400, Eitan Adler wrote: >> On Thu, Aug 22, 2013 at 4:49 PM, Jeremie Le Hen wrote: >> > Well, whatever, if you have any concerns, objections or comments, please >> > speak now :). >> >> This LGTM but please include a comment above the warning with a date / >> release number when this compatibility can be removed. > > If the old variable names are deprecated in releng/10, they can be > removed in releng/11, can't they? Yes, and this should be indicated in a comment. When I see "deprecated" or "old hack" or similar terms in code it takes some archaeology to figure out when it was added and when it could be removed. It would be nice to help the future reader a bit. -- Eitan Adler