From owner-svn-src-head@freebsd.org  Thu Jun  1 16:44:40 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C5A29B7A39E;
 Thu,  1 Jun 2017 16:44:40 +0000 (UTC)
 (envelope-from stevek@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 954E5820CB;
 Thu,  1 Jun 2017 16:44:40 +0000 (UTC)
 (envelope-from stevek@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v51GidRW029412;
 Thu, 1 Jun 2017 16:44:39 GMT (envelope-from stevek@FreeBSD.org)
Received: (from stevek@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v51GidaT029411;
 Thu, 1 Jun 2017 16:44:39 GMT (envelope-from stevek@FreeBSD.org)
Message-Id: <201706011644.v51GidaT029411@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: stevek set sender to
 stevek@FreeBSD.org using -f
From: "Stephen J. Kiernan" <stevek@FreeBSD.org>
Date: Thu, 1 Jun 2017 16:44:39 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r319443 - head/lib/libutil
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jun 2017 16:44:40 -0000

Author: stevek
Date: Thu Jun  1 16:44:39 2017
New Revision: 319443
URL: https://svnweb.freebsd.org/changeset/base/319443

Log:
  When sysctlbyname fails, free buf before returning.
  
  Submitted by:	Thomas Rix <trix@juniper.net>
  Reviewed by:	jhb
  Approved by:	sjg (mentor)
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D9867

Modified:
  head/lib/libutil/kinfo_getvmobject.c

Modified: head/lib/libutil/kinfo_getvmobject.c
==============================================================================
--- head/lib/libutil/kinfo_getvmobject.c	Thu Jun  1 16:03:01 2017	(r319442)
+++ head/lib/libutil/kinfo_getvmobject.c	Thu Jun  1 16:44:39 2017	(r319443)
@@ -46,8 +46,10 @@ kinfo_getvmobject(int *cntp)
 
 	buf = NULL;
 	for (i = 0; i < 3; i++) {
-		if (sysctlbyname("vm.objects", NULL, &len, NULL, 0) < 0)
+		if (sysctlbyname("vm.objects", NULL, &len, NULL, 0) < 0) {
+			free(buf);
 			return (NULL);
+		}
 		buf = reallocf(buf, len);
 		if (buf == NULL)
 			return (NULL);