From owner-freebsd-bugs@FreeBSD.ORG Mon May 2 16:00:19 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A8E21065670 for ; Mon, 2 May 2011 16:00:19 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 631438FC0C for ; Mon, 2 May 2011 16:00:19 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p42G0JIT033238 for ; Mon, 2 May 2011 16:00:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p42G0JWd033237; Mon, 2 May 2011 16:00:19 GMT (envelope-from gnats) Resent-Date: Mon, 2 May 2011 16:00:19 GMT Resent-Message-Id: <201105021600.p42G0JWd033237@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexandr Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB3ED1065670 for ; Mon, 2 May 2011 15:55:23 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id C06458FC0C for ; Mon, 2 May 2011 15:55:23 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p42FtNxu034309 for ; Mon, 2 May 2011 15:55:23 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p42FtNgH034308; Mon, 2 May 2011 15:55:23 GMT (envelope-from nobody) Message-Id: <201105021555.p42FtNgH034308@red.freebsd.org> Date: Mon, 2 May 2011 15:55:23 GMT From: Alexandr To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/156768: sockstat: missing spaces between long fields in output X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 16:00:19 -0000 >Number: 156768 >Category: misc >Synopsis: sockstat: missing spaces between long fields in output >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon May 02 16:00:19 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Alexandr >Release: 7.2 RELEASE-p8 >Organization: NetAssist >Environment: FreeBSD homecat.alter.org.ua 7.2-RELEASE-p8 FreeBSD 7.2-RELEASE-p8 #6: Sat Apr 23 12:52:20 EEST 2011 root@homecat.alter.org.ua:/usr/src/sys/i386/compile/CAT_v14c i386 >Description: FD field is too narrow. Space between columns may be missing if we have too large value. >How-To-Repeat: >Fix: http://alter.org.ua/soft/fbsd/sockstat/fbsd72.sockstat.20110501.patch.gz Patch attached with submission follows: diff -crN orig/usr.bin/sockstat/sockstat.c new/usr.bin/sockstat/sockstat.c *** orig/usr.bin/sockstat/sockstat.c Wed Apr 20 10:38:46 2011 --- new/usr.bin/sockstat/sockstat.c Wed Apr 20 10:38:46 2011 *************** *** 587,610 **** pos += xprintf("%lu", (u_long)xf->xf_uid); else pos += xprintf("%s", pwd->pw_name); ! while (pos < 9) pos += xprintf(" "); ! pos += xprintf("%.10s", getprocname(xf->xf_pid)); ! while (pos < 20) pos += xprintf(" "); ! pos += xprintf("%lu", (u_long)xf->xf_pid); ! while (pos < 26) pos += xprintf(" "); ! pos += xprintf("%d", xf->xf_fd); ! while (pos < 33) pos += xprintf(" "); ! pos += xprintf("%s", s->protoname); if (s->vflag & INP_IPV4) pos += xprintf("4"); if (s->vflag & INP_IPV6) pos += xprintf("6"); ! while (pos < 40) pos += xprintf(" "); switch (s->family) { case AF_INET: case AF_INET6: --- 587,611 ---- pos += xprintf("%lu", (u_long)xf->xf_uid); else pos += xprintf("%s", pwd->pw_name); ! while (pos < 8) pos += xprintf(" "); ! pos += xprintf(" %.10s", getprocname(xf->xf_pid)); ! while (pos < 19) pos += xprintf(" "); ! pos += xprintf(" %lu", (u_long)xf->xf_pid); ! while (pos < 25) pos += xprintf(" "); ! pos += xprintf(" %d", xf->xf_fd); ! while (pos < 32) pos += xprintf(" "); ! pos += xprintf(" %s", s->protoname); if (s->vflag & INP_IPV4) pos += xprintf("4"); if (s->vflag & INP_IPV6) pos += xprintf("6"); ! while (pos < 39) pos += xprintf(" "); + pos += xprintf(" "); switch (s->family) { case AF_INET: case AF_INET6: >Release-Note: >Audit-Trail: >Unformatted: