From owner-freebsd-arm@FreeBSD.ORG  Sun Dec 15 17:39:07 2013
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3B10C219
 for <freebsd-arm@freebsd.org>; Sun, 15 Dec 2013 17:39:07 +0000 (UTC)
Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198])
 by mx1.freebsd.org (Postfix) with ESMTP id 1C5781351
 for <freebsd-arm@freebsd.org>; Sun, 15 Dec 2013 17:39:06 +0000 (UTC)
Received: from bender.Home (97e07ae8.skybroadband.com [151.224.122.232])
 by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id 85BA15DFFE;
 Sun, 15 Dec 2013 17:30:49 +0000 (UTC)
Date: Sun, 15 Dec 2013 17:30:42 +0000
From: Andrew Turner <andrew@fubar.geek.nz>
To: Howard Su <howard0su@gmail.com>
Subject: Re: [PATCH] Add stack unwind support for the functions in .ko
Message-ID: <20131215173042.0dead636@bender.Home>
In-Reply-To: <CAAvnz_p2vw9=HWbGPePKm_yDxM-bM1h6VaQBeJq9sYXPRb2-Lg@mail.gmail.com>
References: <CAAvnz_pWZqw-HEB-GTJ_CkErjXrz3v7ozabMXE__vr=SfkBVSg@mail.gmail.com>
 <CAAvnz_p2vw9=HWbGPePKm_yDxM-bM1h6VaQBeJq9sYXPRb2-Lg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: freebsd-arm <freebsd-arm@freebsd.org>
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Dec 2013 17:39:07 -0000

On Mon, 9 Dec 2013 22:44:14 +0800
Howard Su <howard0su@gmail.com> wrote:

> Here is a new version which solve the unreadable $a problem. (the fix
> is in ddb/db_main.c in the end of the patch.)
> 
> I attached the diff for review.

I can't comment on the MD parts of the code, but the ARM change looks
good. My only request is to add a kernel option to turn on printing the
registers in the stack trace as it has been useful for tracking down
bugs.

Andrew