Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Dec 2012 12:58:37 +0400
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Adrian Chadd <adrian@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, John Baldwin <jhb@FreeBSD.org>, svn-src-all@FreeBSD.org, Alfred Perlstein <alfred@FreeBSD.org>, Andriy Gapon <avg@FreeBSD.org>, svn-src-head@FreeBSD.org
Subject:   Re: svn commit: r244112 - head/sys/kern
Message-ID:  <20121213085837.GO97487@FreeBSD.org>
In-Reply-To: <CAJ-Vmo=S_pPROzrR1s5iL8C86iF4K73bb5A2kt3DPydaLkBnqw@mail.gmail.com>
References:  <201212110708.qBB78EWx025288@svn.freebsd.org> <201212121046.43706.jhb@freebsd.org> <CAJ-Vmo=U04GX%2BZyKuzXLwV%2BPpzU6_dm5BCmL=DWfsmhTVAR%2BsA@mail.gmail.com> <201212121658.49048.jhb@freebsd.org> <50C90567.8080406@FreeBSD.org> <CAJ-Vmo=sP0uojVBM9MdY7jL%2BUZoN5mj%2Bim_MBdq9U%2B8uRuTv3A@mail.gmail.com> <50C97A11.10409@FreeBSD.org> <CAJ-Vmo=S_pPROzrR1s5iL8C86iF4K73bb5A2kt3DPydaLkBnqw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 12, 2012 at 10:49:44PM -0800, Adrian Chadd wrote:
A> Let me restate it again.
A> 
A> We can ship a STABLE kernel with INVARIANTS enabled, and it not be any
A> less stable than the STABLE kernel is today.

It will be less stable, at least due to thrashing memory on free(9).
Accessing memory after free(9) is a quite a common bug.

However, with current semantics of KASSERT it will panic with good
diagnostics and early, on malloc(9). With perverted semantics that Alfred
suggests and you advocate it won't panic on malloc(9), but will panic later
(no doubt that it will, if a thrashed pointer is dereferenced) with much
more obscure diagnostics.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121213085837.GO97487>