From owner-svn-src-all@FreeBSD.ORG Thu Dec 13 08:58:46 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A2368742; Thu, 13 Dec 2012 08:58:46 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) by mx1.freebsd.org (Postfix) with ESMTP id A19E78FC1F; Thu, 13 Dec 2012 08:58:45 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id qBD8wbpc009053; Thu, 13 Dec 2012 12:58:37 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id qBD8wb8S009052; Thu, 13 Dec 2012 12:58:37 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 13 Dec 2012 12:58:37 +0400 From: Gleb Smirnoff To: Adrian Chadd Subject: Re: svn commit: r244112 - head/sys/kern Message-ID: <20121213085837.GO97487@FreeBSD.org> References: <201212110708.qBB78EWx025288@svn.freebsd.org> <201212121046.43706.jhb@freebsd.org> <201212121658.49048.jhb@freebsd.org> <50C90567.8080406@FreeBSD.org> <50C97A11.10409@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: src-committers@FreeBSD.org, John Baldwin , svn-src-all@FreeBSD.org, Alfred Perlstein , Andriy Gapon , svn-src-head@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2012 08:58:46 -0000 On Wed, Dec 12, 2012 at 10:49:44PM -0800, Adrian Chadd wrote: A> Let me restate it again. A> A> We can ship a STABLE kernel with INVARIANTS enabled, and it not be any A> less stable than the STABLE kernel is today. It will be less stable, at least due to thrashing memory on free(9). Accessing memory after free(9) is a quite a common bug. However, with current semantics of KASSERT it will panic with good diagnostics and early, on malloc(9). With perverted semantics that Alfred suggests and you advocate it won't panic on malloc(9), but will panic later (no doubt that it will, if a thrashed pointer is dereferenced) with much more obscure diagnostics. -- Totus tuus, Glebius.