Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Feb 2012 22:56:34 -0500
From:      Eitan Adler <eadler@freebsd.org>
To:        Hiroki Sato <hrs@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r231817 - head/usr.sbin/IPXrouted
Message-ID:  <CAF6rxgmp%2BqzvGV5Ey%2BBgcUfHQEcQ-Gonb0ww_s36oo4VZXKqww@mail.gmail.com>
In-Reply-To: <20120216.164332.2209961872967607025.hrs@allbsd.org>
References:  <201202160517.q1G5H6Z0000155@svn.freebsd.org> <201202160517.q1G5H14i000118@svn.freebsd.org> <20120216.164332.2209961872967607025.hrs@allbsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 16, 2012 at 2:43 AM, Hiroki Sato <hrs@freebsd.org> wrote:
> Eitan Adler <eadler@FreeBSD.org> wrote
> =C2=A0The oldroute is still used in the #ifdef section at the end of this
> =C2=A0function.

:( I will try to come up with a fix this weekend.

> =C2=A0This file was from NetBSD and this change just increased the diff.
<insert rant about contrib code not living in contrib>

> I do not understand why the prototype declaration of MCReadCat() was
> =C2=A0left while the main body was removed.

My fault, I should have removed both (if the commit was valid in the
first place).

> =C2=A0IMHO it is not a good idea to remove unused code partially like thi=
s
> =C2=A0or unused code in one from another project if you just want to
> =C2=A0suppress a compiler warning.

I have a slightly larger goal in mind: a usable world built with
gcc46. How soon, if ever, we will see this goal realized is a
different question. It would be nice to not be restricted to one (or
two) compiler options.

>  It may suppress the warning, but
> =C2=A0remaining bits in comments and/or conditional parts where the
> =C2=A0compiler does not complain make developers confused. =C2=A0I think =
it is
> =C2=A0more harmful than the warning.

I need to be more vigilant about ensuring that I am not removing
useful code. This warning is either indicative of a bug or results in
useless code. There are some cases where fixing the warning results in
problems but I try to avoid them, but a few inevitably slip through.


--=20
Eitan Adler
Source & Ports committer
X11, Bugbusting teams



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgmp%2BqzvGV5Ey%2BBgcUfHQEcQ-Gonb0ww_s36oo4VZXKqww>