From owner-svn-src-head@FreeBSD.ORG Fri Feb 17 03:57:06 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E98A1065670; Fri, 17 Feb 2012 03:57:06 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 243A88FC0C; Fri, 17 Feb 2012 03:57:04 +0000 (UTC) Received: by werm13 with SMTP id m13so2527532wer.13 for ; Thu, 16 Feb 2012 19:57:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=+CRTTl88fZGjd1Vcp4x7/uCEPLOvxZmSTGHRxCStI5M=; b=VJqVcmpiRf1F+PMCf4LiiCLwNmy347xK4I16S/sYUwg+bnsL6ZYL15TsjOLP2yPyun bGHMIcEvilEnnaFzqbG7lXEYps8zdhTXN+ISqVOILagrTUu9ISflDMs1i6zSH+AYCdjI N3Vk6BpB20pAfbBmtQawmrdmA91Fmvb9fgoFA= Received: by 10.180.77.228 with SMTP id v4mr743985wiw.2.1329451024189; Thu, 16 Feb 2012 19:57:04 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.223.15.90 with HTTP; Thu, 16 Feb 2012 19:56:34 -0800 (PST) In-Reply-To: <20120216.164332.2209961872967607025.hrs@allbsd.org> References: <201202160517.q1G5H6Z0000155@svn.freebsd.org> <201202160517.q1G5H14i000118@svn.freebsd.org> <20120216.164332.2209961872967607025.hrs@allbsd.org> From: Eitan Adler Date: Thu, 16 Feb 2012 22:56:34 -0500 X-Google-Sender-Auth: sokSp9cPrty2vxqHi_O2yYuEXpk Message-ID: To: Hiroki Sato Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQn1ntCqS4wT+S7KvdRjw3l5mV1u+7XiUhjYwY3Ud62KjoC0323bU8avNci/oDMtcG+ziIOm Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r231817 - head/usr.sbin/IPXrouted X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2012 03:57:06 -0000 On Thu, Feb 16, 2012 at 2:43 AM, Hiroki Sato wrote: > Eitan Adler wrote > =C2=A0The oldroute is still used in the #ifdef section at the end of this > =C2=A0function. :( I will try to come up with a fix this weekend. > =C2=A0This file was from NetBSD and this change just increased the diff. > I do not understand why the prototype declaration of MCReadCat() was > =C2=A0left while the main body was removed. My fault, I should have removed both (if the commit was valid in the first place). > =C2=A0IMHO it is not a good idea to remove unused code partially like thi= s > =C2=A0or unused code in one from another project if you just want to > =C2=A0suppress a compiler warning. I have a slightly larger goal in mind: a usable world built with gcc46. How soon, if ever, we will see this goal realized is a different question. It would be nice to not be restricted to one (or two) compiler options. > It may suppress the warning, but > =C2=A0remaining bits in comments and/or conditional parts where the > =C2=A0compiler does not complain make developers confused. =C2=A0I think = it is > =C2=A0more harmful than the warning. I need to be more vigilant about ensuring that I am not removing useful code. This warning is either indicative of a bug or results in useless code. There are some cases where fixing the warning results in problems but I try to avoid them, but a few inevitably slip through. --=20 Eitan Adler Source & Ports committer X11, Bugbusting teams