Date: Mon, 9 Mar 2020 01:53:14 +0000 (UTC) From: Conrad Meyer <cem@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r528087 - head/www/chromium/files Message-ID: <202003090153.0291rExM088707@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: cem (src committer) Date: Mon Mar 9 01:53:13 2020 New Revision: 528087 URL: https://svnweb.freebsd.org/changeset/ports/528087 Log: www/chromium: Reduce build log spam Avoid build log spam by disabling a noisy and purely false-positive warning in targeted locations. The Clang static analysis of pthread locking primitives assumes they are not wrapped (as well as relatively simple locking use). These headers simply wrap the underlying primitives and tickle hundreds of false positives with deep include stacks that spam build logs. Approved by: jrm Differential Revision: https://reviews.freebsd.org/D24000 Added: head/www/chromium/files/patch-base_synchronization_lock__impl.h (contents, props changed) head/www/chromium/files/patch-third__party_webrtc_rtc__base_third__party_sigslot_sigslot.h (contents, props changed) Added: head/www/chromium/files/patch-base_synchronization_lock__impl.h ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/www/chromium/files/patch-base_synchronization_lock__impl.h Mon Mar 9 01:53:13 2020 (r528087) @@ -0,0 +1,16 @@ +--- base/synchronization/lock_impl.h.orig 2020-03-08 08:35:16 UTC ++++ base/synchronization/lock_impl.h +@@ -67,10 +67,13 @@ void LockImpl::Unlock() { + ::ReleaseSRWLockExclusive(reinterpret_cast<PSRWLOCK>(&native_handle_)); + } + #elif defined(OS_POSIX) || defined(OS_FUCHSIA) ++#pragma GCC diagnostic push ++#pragma GCC diagnostic ignored "-Wthread-safety-analysis" + void LockImpl::Unlock() { + int rv = pthread_mutex_unlock(&native_handle_); + DCHECK_EQ(rv, 0) << ". " << strerror(rv); + } ++#pragma GCC diagnostic pop + #endif + + // This is an implementation used for AutoLock templated on the lock type. Added: head/www/chromium/files/patch-third__party_webrtc_rtc__base_third__party_sigslot_sigslot.h ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/www/chromium/files/patch-third__party_webrtc_rtc__base_third__party_sigslot_sigslot.h Mon Mar 9 01:53:13 2020 (r528087) @@ -0,0 +1,19 @@ +--- third_party/webrtc/rtc_base/third_party/sigslot/sigslot.h.orig 2020-03-03 18:55:31 UTC ++++ third_party/webrtc/rtc_base/third_party/sigslot/sigslot.h +@@ -178,6 +178,8 @@ class multi_threaded_local { + #endif // _SIGSLOT_HAS_WIN32_THREADS + + #ifdef _SIGSLOT_HAS_POSIX_THREADS ++#pragma GCC diagnostic push ++#pragma GCC diagnostic ignored "-Wthread-safety-analysis" + // The multi threading policies only get compiled in if they are enabled. + class multi_threaded_global { + public: +@@ -201,6 +203,7 @@ class multi_threaded_local { + private: + pthread_mutex_t m_mutex; + }; ++#pragma GCC diagnostic pop + #endif // _SIGSLOT_HAS_POSIX_THREADS + + template <class mt_policy>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202003090153.0291rExM088707>