From owner-freebsd-bugs@FreeBSD.ORG Thu Apr 6 05:00:34 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A53416A439 for ; Thu, 6 Apr 2006 05:00:34 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99B5943D69 for ; Thu, 6 Apr 2006 05:00:33 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3650XlH083226 for ; Thu, 6 Apr 2006 05:00:33 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3650XZE083225; Thu, 6 Apr 2006 05:00:33 GMT (envelope-from gnats) Resent-Date: Thu, 6 Apr 2006 05:00:33 GMT Resent-Message-Id: <200604060500.k3650XZE083225@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Bryan Venteicher" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1CC316A420 for ; Thu, 6 Apr 2006 04:52:55 +0000 (UTC) (envelope-from bryanv@daemoninthecloset.org) Received: from sccmmhc92.asp.att.net (sccmmhc92.asp.att.net [204.127.203.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id EFB2F43D45 for ; Thu, 6 Apr 2006 04:52:54 +0000 (GMT) (envelope-from bryanv@daemoninthecloset.org) Received: from torment.daemoninthecloset.org ([12.219.231.23]) by sccmmhc92.asp.att.net (sccmmhc92) with ESMTP id <20060406045253m92001a8k6e>; Thu, 6 Apr 2006 04:52:53 +0000 Received: from misery.daemoninthecloset.org (daemongateway1.student.iastate.edu [64.113.65.231]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "misery.daemoninthecloset.org", Issuer "CA Cert Signing Authority" (verified OK)) by torment.daemoninthecloset.org (Postfix) with ESMTP id 3AFBE70 for ; Wed, 5 Apr 2006 23:56:14 -0500 (CDT) Received: from localhost (misery.daemoninthecloset.org [192.168.1.25]) by misery.daemoninthecloset.org (Postfix) with ESMTP id 5ECDD566D3 for ; Wed, 5 Apr 2006 23:52:48 -0500 (CDT) Received: from misery.daemoninthecloset.org ([192.168.1.25]) by localhost (misery.daemoninthecloset.org [192.168.1.25]) (amavisd-new, port 10024) with ESMTP id 06961-09 for ; Wed, 5 Apr 2006 23:52:47 -0500 (CDT) Received: from agonize.daemoninthecloset.org (agonize.daemoninthecloset.org [192.168.1.30]) by misery.daemoninthecloset.org (Postfix) with ESMTP id 61F8C5645A for ; Wed, 5 Apr 2006 23:52:47 -0500 (CDT) Message-Id: <1144299167.27963@agonize.daemoninthecloset.org> Date: Wed, 5 Apr 2006 23:52:47 -0500 From: "Bryan Venteicher" To: "FreeBSD gnats submit" X-Send-Pr-Version: gtk-send-pr 0.4.7 Cc: Subject: kern/95391: [patch] minor if_bfe error X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2006 05:00:34 -0000 >Number: 95391 >Category: kern >Synopsis: [patch] minor if_bfe error >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Apr 06 05:00:32 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Bryan Venteicher >Release: FreeBSD 6.1-PRERELEASE i386 >Organization: >Environment: System: FreeBSD 6.1-PRERELEASE #1: Thu Mar 16 21:35:38 CST 2006 bryanv@agonize.daemoninthecloset.org:/home/bryanv/obj/usr/src/sys/AGONIZE >Description: In the first call to bus_dma_tag_create() in bfe_dma_alloc() in if_bfe.c seems to have the lowaddr and highaddr parameters switched. I'm not very familiar with the DMA stuff but every other ethernet driver seems the parameters in the other order. >From how the constants are defined, it seems this would potentially only effect a very small number of users. >How-To-Repeat: >Fix: --- if_bfe.c.diff begins here --- --- if_bfe.c.orig Wed Apr 5 23:45:35 2006 +++ if_bfe.c Wed Apr 5 23:46:09 2006 @@ -200,8 +200,8 @@ /* parent tag */ error = bus_dma_tag_create(NULL, /* parent */ PAGE_SIZE, 0, /* alignment, boundary */ - BUS_SPACE_MAXADDR, /* lowaddr */ - BUS_SPACE_MAXADDR_32BIT, /* highaddr */ + BUS_SPACE_MAXADDR_32BIT, /* lowaddr */ + BUS_SPACE_MAXADDR, /* highaddr */ NULL, NULL, /* filter, filterarg */ MAXBSIZE, /* maxsize */ BUS_SPACE_UNRESTRICTED, /* num of segments */ --- if_bfe.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: