From nobody Wed Dec 14 09:21:01 2022 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NX8xB1Jrzz4k8VP for ; Wed, 14 Dec 2022 09:21:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NX8x96NYbz3xx2 for ; Wed, 14 Dec 2022 09:21:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671009661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tFr+6yIpyEm8VQRwDpC4DUN92VDosB/CuTFuvkxtPuc=; b=oLIOOp+ugJhaZck/x75hmsKBXVnfMBtlJfiLXmnXQo6FAwLQ3ORrGA03M5CeyKwa9vAV/r PnQRkqllVcrsY7FZVzUTvOMnKv6Y8DM8Y/xFHqwDqLCbpalQ9aqeZ1d2hpfC++IzWKxE7K ed/duEg7eupF5c76jgf5e0pi8xdet/7l28uvVhf+MPoU9yQCLTEG1KX37IEhNPj+Q6nS0E +I1RvjaUfqg8yh7/XPMG3AK0Gd5DprE+CJZrHJZD8EPgk0UEY4yfe1zffVHh0OkyGahy4d 2eP3+sbM9l1vwImR0K48fFkQkKVyhLbVaLTqlJccuRCwVFi9clLalqi+4FIr2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1671009661; a=rsa-sha256; cv=none; b=djo3cxkLVV3wRqrlIUUf1KJ+ox+IOBWvhyTnrurL42ZjfVsbJyqXY+2/xW/d/s16G5mTNT j2Z5mcnTZAnyd22Ap/P1PPIdtRwgGXefg3n/gUI0WanV5IhPgB5CEvVOh9QyVsY2/686hP Z0VNd9ZUAmtHAm0qGN7mfc2lQ9sSNt7r8KIiYJXbs42x0+ciCz+zlkgPtP/SQpbL8ub1HU x/1tuSQsOAJ2MKKNfCc0u3z/BVIrlaNsjOmP3TORu64fZjYKdSu8OP9iO+JJ+1MbLMvqbb NAo3bhSNLLBE9czTuxvwdumJyIk1MqN6gs0nVPrx4LRrYhKu30rH7MikRdLmQA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NX8x95SgwzpGm for ; Wed, 14 Dec 2022 09:21:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2BE9L14f060773 for ; Wed, 14 Dec 2022 09:21:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2BE9L1m9060772 for pf@FreeBSD.org; Wed, 14 Dec 2022 09:21:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 257218] pfi_ifnet leak on interface removal Date: Wed, 14 Dec 2022 09:21:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257218 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dbfeef0d32a0036bf6bec93a439e0466ef= e6f4482 commit bfeef0d32a0036bf6bec93a439e0466efe6f4482 Author: Nick Reilly AuthorDate: 2022-11-30 14:19:44 +0000 Commit: Kristof Provost CommitDate: 2022-12-14 09:19:01 +0000 pf: fix pfi_ifnet leak on interface removal The detach of the interface and group were leaving pfi_ifnet memory behind. Check if the kif still has references, and clean it up if it doesn't On interface detach, the group deletion was notified first and then a change notification was sent. This would recreate the group in the kif layer. Reorder the change to before the delete. PR: 257218 MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D37569 sys/net/if.c | 3 +-- sys/netpfil/pf/pf_if.c | 23 ++++++++++++++++++----- 2 files changed, 19 insertions(+), 7 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=