From owner-svn-src-projects@FreeBSD.ORG Mon Oct 29 18:22:03 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 223AD413; Mon, 29 Oct 2012 18:22:03 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 8D8B38FC12; Mon, 29 Oct 2012 18:22:01 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id e12so5090076lag.13 for ; Mon, 29 Oct 2012 11:22:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=FJ/p5gqovwPZuMifMrk4aCXDj7dq8bl1zDUb0wzzkXA=; b=ll6q2vlZkzXPk3WU7ppIWv0fxSw0OerhbHPmma+fpXpFz2kUPW7DIS7Ret2odCElO1 HVXGG3YAj5mZ/RK+iqQfCLRHYV7NYK2NV6REg61ZusVRjBmoJyC+Xt0Z5g3SCZJTqAF8 dwzoIeI2Rgt/dF88DCTLNWFqFFmNjzDJnuve/qOFVgESvQqM45ec5R1LKl1eZAjrbaLx /IH+6ryuvN/N0BmjiBGJRjk9ekvokqFwSMWCeCwLAA7kyToWr5Uhy0hRLD2VMglHi2T3 kYFzN60/JtZEG3j0kKVn9mz2brN+Z9x0Uv8Lk4ENFwbyWmlHVQmlAouPkctHCoSL7d2q Kg5Q== MIME-Version: 1.0 Received: by 10.152.123.103 with SMTP id lz7mr27794828lab.21.1351534920471; Mon, 29 Oct 2012 11:22:00 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.30.37 with HTTP; Mon, 29 Oct 2012 11:22:00 -0700 (PDT) In-Reply-To: <20121030043922.H8166@besplex.bde.org> References: <201207301350.q6UDobCI099069@svn.freebsd.org> <201207301732.33474.jhb@freebsd.org> <20121029155136.O943@besplex.bde.org> <20121030014250.D5191@besplex.bde.org> <20121030043922.H8166@besplex.bde.org> Date: Mon, 29 Oct 2012 18:22:00 +0000 X-Google-Sender-Auth: xwMUliUgFQYPoMrq-CnvA074O4o Message-ID: Subject: Re: svn commit: r238907 - projects/calloutng/sys/kern From: Attilio Rao To: Bruce Evans Content-Type: text/plain; charset=UTF-8 Cc: src-committers@freebsd.org, John Baldwin , Jeff Roberson , Florian Smeets , Bruce Evans , svn-src-projects@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2012 18:22:03 -0000 On 10/29/12, Bruce Evans wrote: > On Mon, 29 Oct 2012, Attilio Rao wrote: > [ trimm ] > > The above is mostly about -current. My previous mail discussed why > uninlining mtx_lock/unlock() doesn't work so well. It is because these > macros are shorter and don't make unconditional function calls, so > inlining of them has better chances of improving their efficiency, and > in fact does. Again you are mentioning mtx_lock/unlock() but this has nothing to do with them, this is about mtx_lock_spin(). However, I quite see your point and honestly I always thought that inlining mtx_lock_spin() wasn't really useful because of the function call themselves from spinlock_enter(). However, in order to get to a version which *doesn't* inline them we should have a clear win which I don't think it is there (this is too dependent by the arch), so I would say to stick with what the current code does. Attilio -- Peace can only be achieved by understanding - A. Einstein