Date: Tue, 19 Jan 2016 16:40:54 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291941 - in head: lib/libpam/modules/pam_ssh secure/lib/libssh secure/libexec/sftp-server secure/libexec/ssh-keysign secure/libexec/ssh-pkcs11-helper secure/usr.bin/scp secure/usr.bin/... Message-ID: <569ED796.6030300@FreeBSD.org> In-Reply-To: <569E7524.5040806@FreeBSD.org> References: <201512071608.tB7G89BZ095366@repo.freebsd.org> <86vb6phdug.fsf@desk.des.no> <569E60BA.6050007@FreeBSD.org> <569E7524.5040806@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TvTqboptPtXcfQXTHQCRttLBeSjRuiGE0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/19/2016 9:40 AM, Bryan Drewery wrote: > On 1/19/2016 8:13 AM, Bryan Drewery wrote: >> On 1/19/2016 5:56 AM, Dag-Erling Sm=C3=B8rgrav wrote: >>> Bryan Drewery <bdrewery@FreeBSD.org> writes: >>>> Log: >>>> Replace unneeded manual dependency on header by adding it to SRCS.= >>>> =20 >>>> bsd.lib.mk and bsd.prog.mk already depend all objs on headers in S= RCS if >>>> there is not yet a depend file. The headers in SRCS are never bui= lt or >>>> installed. After 'make depend' the header was already added as a = proper >>>> dependency on the objects where needed. >>> >>> This doesn't work. Try the following: >>> >>> $ cd /usr/src/secure/lib/libssh >>> $ make depend && make >>> $ touch /usr/src/crypto/openssh/ssh_namespace.h >>> $ make >> >> Well, it sort of works with WITH_FAST_DEPEND which will be default ver= y >> shortly. >> > ... >>> $ grep -c ssh_namespace $(make -V.OBJDIR)/.depend >>> 0 >>> >> >> That is expected. The dependency is defined in bsd.lib.mk. Granted it = is >> dependent on .depend existing, but I am going to remove that check so = it >> is always defined. >> >=20 > The problem with the old method (mkdep which is still default) is that > the -include is not passed to mkdep. FAST_DEPEND does not have that > issue since it generates the .depend files during compilation, where th= e > -include is present. >=20 >=20 It's manifesting for people now with -DNO_CLEAN using mkdep. I'm working on a solution rather than reverting. /usr/obj/usr/src/tmp/usr/lib/libprivatessh.so: undefined reference to `Fssh_crypto_scalarmult_curve25519' --=20 Regards, Bryan Drewery --TvTqboptPtXcfQXTHQCRttLBeSjRuiGE0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWnteWAAoJEDXXcbtuRpfPsjQH/RWW0mbcgtML62Xbaaf/5BKU WPwd9uIv1zRsAyqC3Wh/KyCI5pEHqwAbIbzZ4ogX9ZjGsQSZMM8XTSUC/1n4RiIT hVnjd9F8TGDxS2uHBZK/GbQ+gF3KFKhRd8+iDipB1ZNgE/6SJKbqrg+Yo7CWlRet gjqJ42R5H2FHpk/Ez7QXWKmsodNWEkjRrTQCLKyzpdK6YFe/qIVD+2s1EvDoYmeR Ci/iuHDVDH9povezucjFiad1wXlRuC1QNt5gxANiREk6gJymGlqHV3t/wHshV8+0 63q6nzPSAsKT2plSz68bBbNue+TkjKlgUSCyPWExfVZDsWP8psyaGodohrBaOXw= =UEaS -----END PGP SIGNATURE----- --TvTqboptPtXcfQXTHQCRttLBeSjRuiGE0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?569ED796.6030300>