From nobody Wed Mar 26 21:16:23 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZNKN867Cbz5rD5c; Wed, 26 Mar 2025 21:16:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZNKN80QFsz3nn2; Wed, 26 Mar 2025 21:16:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743023784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ynhKWzY+0vIP2JU7IEpKYwmJAEXzH0UYUi9GiNeUP90=; b=V7mWncJGNYwWmu6OQ7tFUJ6yyVdarIL360mmGbLKP03qkp+ocf6FwS55ekQ99iNE2KSaxJ /9bpHQfcvQAXoWlV1TzqNNwjWRpeKDEXG5do1scYbV1Vl7OjBH8EWo91Ncs7yVQpxwFX/J n5ObamCN3XhnhZGht61giO3mPeF3Uy15RnndhdiyTvhUNg+Rim9TEinrbRWcIQJuSyyo1M tmqub42+Rr2KeXE7KNrPuY6FBSzl5cJNoJb3uwX0Kh8GI1rtO9EdMHnZ9Bz6R25WI0yySl MWL9XzxX5ErhNS3P+Pgbz2OZsTocrelNiu7mNz8ldwR7/VPiVf46wPwtvi0Sog== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743023784; a=rsa-sha256; cv=none; b=hffwtpR7Mg6awjeSUlfP4DWG7BNc79yYNrEHR7PuIzcOVfzfJos/Sj/SlOx5gXw5SbIQ3+ bqXpbeqpARViL0AST8U+68mPx6bmIBtU0hYQtdvgdEhBW1DjLrDGMviP0xiGoM9fhsQlyH Yvlk4vXW9kaDOFzjE4BWVoALglxpvteN6Lji2jhK7NIlKrQ6O7GhHiSIH8Bl86s1+kyFIT WxJLw2aYAe7GeiSLMpdr4PxA8bu0FmbwqO0IzBNSl1oOhZGrL6twzmG7UsDtdkLde+/i1g Je/BZS/xK35X/bOiJ7ieNu5mENEO6F0Z+mIzgn6WTBeY+QFmR7fXcCPxAIshzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743023784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ynhKWzY+0vIP2JU7IEpKYwmJAEXzH0UYUi9GiNeUP90=; b=NK0NvW+Zu0YkEgqEvMy+6+5DbTDtCTgdLNRujx3qhhmdlQ6+0nBccm9C36dg46GaMrxgv5 Taze3xHf9FuaLYSvHXLCrbsCdtFywE83IxE7GAgnCZ/JSNWZ6NR3FOfjlwaFeqttw61Wrx talDBGY3g/SJP1JVnT1OfnvblrUlwilmfaQ2EtWxuDQ51SYCXdYqezabRGvcueATWpXbvT pIxYzURYYZ2z70D4+pi4Luwnl56als7RGbMzAG6O4YBZd9KGkL3ED4dzZsyjHdCLPBkuyP 1jkiN4McOybZNWhNXrOa6gvT8K7FsXyIjhDb8UKPSYcghxOBYT+9l53WnMPEFQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZNKN771hTzBtY; Wed, 26 Mar 2025 21:16:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52QLGNfR070763; Wed, 26 Mar 2025 21:16:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52QLGNwX070760; Wed, 26 Mar 2025 21:16:23 GMT (envelope-from git) Date: Wed, 26 Mar 2025 21:16:23 GMT Message-Id: <202503262116.52QLGNwX070760@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Enji Cooper Subject: git: f7d46b858a54 - stable/13 - radlib: fix a memory leak in `is_valid_request` List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: f7d46b858a54cdaf648ff532025b2fd4e34e59a5 Auto-Submitted: auto-generated The branch stable/13 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=f7d46b858a54cdaf648ff532025b2fd4e34e59a5 commit f7d46b858a54cdaf648ff532025b2fd4e34e59a5 Author: Enji Cooper AuthorDate: 2024-06-04 20:01:55 +0000 Commit: Enji Cooper CommitDate: 2025-03-26 21:15:25 +0000 radlib: fix a memory leak in `is_valid_request` Call `HMAC_CTX_free` if returning early from `is_valid_request` when processing `Message-Authenticator` tags. Reported by: Coverity MFC after: 1 week Fixes: 8d5c7813061d ("libradius: Fix input validation bugs") Differential Revision: https://reviews.freebsd.org/D45488 (cherry picked from commit 77c04f3eb12a560eb61252c817e4147bc0178e43) --- lib/libradius/radlib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/libradius/radlib.c b/lib/libradius/radlib.c index 2049468f455f..cd1f1df1b234 100644 --- a/lib/libradius/radlib.c +++ b/lib/libradius/radlib.c @@ -321,8 +321,10 @@ is_valid_request(struct rad_handle *h) hctx = HMAC_CTX_new(); while (pos < len - 2) { alen = h->in[pos + 1]; - if (alen < 2) + if (alen < 2) { + HMAC_CTX_free(hctx); return (0); + } if (h->in[pos] == RAD_MESSAGE_AUTHENTIC) { if (len - pos < MD5_DIGEST_LENGTH + 2) { HMAC_CTX_free(hctx);