From owner-svn-src-head@freebsd.org Wed May 30 13:34:29 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 68507EFCE79; Wed, 30 May 2018 13:34:29 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EE742836AF; Wed, 30 May 2018 13:34:28 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 61D8E260174; Wed, 30 May 2018 15:34:27 +0200 (CEST) Subject: Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool To: rgrimes@freebsd.org, Antoine Brodin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201805301241.w4UCfhoE071874@pdx.rh.CN85.dnsmgr.net> From: Hans Petter Selasky Message-ID: <34baadb9-ab2c-6740-cc52-8dca80dec934@selasky.org> Date: Wed, 30 May 2018 15:34:13 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201805301241.w4UCfhoE071874@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 13:34:29 -0000 On 05/30/18 14:41, Rodney W. Grimes wrote: >> Either hide remote packet capture functions from the header or enable >> remote capture functions? >> Note that net/p5-Net-Pcap will fail to build with libpcap from ports >> too when libpcap from ports is updated to version 1.9.0 (pre-release). > If there is any thoughs of merging this to stable/11 wont the > HAVE_REMOTE have to be turned on anyway? > > I suppose it get be #ifdef FreeBSD_VERSION. Yes, #if 0 is fine. --HPS