From owner-cvs-all Fri Oct 20 21:11:50 2000 Delivered-To: cvs-all@freebsd.org Received: from sasami.jurai.net (sasami.jurai.net [63.67.141.99]) by hub.freebsd.org (Postfix) with ESMTP id 4729837B479; Fri, 20 Oct 2000 21:11:46 -0700 (PDT) Received: from localhost (winter@localhost) by sasami.jurai.net (8.9.3/8.8.7) with ESMTP id AAA78340; Sat, 21 Oct 2000 00:11:45 -0400 (EDT) Date: Sat, 21 Oct 2000 00:11:44 -0400 (EDT) From: "Matthew N. Dodd" To: KATO Takenori Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 nexus.c src/sys/i386/include bus_pc98.h src/sys/i386/isa isa.c In-Reply-To: <200010200242.TAA31859@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 19 Oct 2000, KATO Takenori wrote: > kato 2000/10/19 19:42:07 PDT > > Modified files: > sys/i386/i386 nexus.c > sys/i386/include bus_pc98.h > sys/i386/isa isa.c > Log: > Convert the type of bus_space_handle_t of pc98 from structure into > pointer to structure. Could you look at moving rman_set_bustag() into the MD bus headers so consumers of it don't have to have any knowledge of the differences? I was pondering something like the following (except not living in sys/rman.h). --- rman.h 2000/10/17 23:45:28 1.10 +++ rman.h 2000/10/18 05:23:33 @@ -105,7 +105,19 @@ #define rman_get_virtual(r) ((r)->r_virtual) #define rman_set_bustag(r,t) ((r)->r_bustag = (t)) #define rman_get_bustag(r) ((r)->r_bustag) +#ifdef PC98 +/* PC-98: the type of bus_space_handle_t is the structure. */ +#define rman_set_bushandle(r,h) do { \ + (r)->r_bushandle.bsh_base = (h); \ + (r)->r_bushandle.bsh_iat = NULL; \ + (r)->r_bushandle.bsh_iatsz = 0; \ + (r)->r_bushandle.bsh_res = NULL; \ + (r)->r_bushandle.bsh_ressz = 0; \ + } while (0); +#else +/* Other: the type of bus_space_handle_t is u_int */ #define rman_set_bushandle(r,h) ((r)->r_bushandle = (h)) +#endif #define rman_get_bushandle(r) ((r)->r_bushandle) extern struct rman_head rman_head; -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | This Space For Rent | ISO8802.5 4ever | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message