From owner-freebsd-gnome@FreeBSD.ORG Tue Feb 21 02:53:57 2006 Return-Path: X-Original-To: gnome@freebsd.org Delivered-To: freebsd-gnome@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED8B116A420; Tue, 21 Feb 2006 02:53:55 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67B5343D45; Tue, 21 Feb 2006 02:53:55 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4]) by creme-brulee.marcuscom.com (8.13.4/8.13.4) with ESMTP id k1L2rvBh015871; Mon, 20 Feb 2006 21:53:58 -0500 (EST) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Alexander Nedotsukov In-Reply-To: <43FA7D9F.5090108@FreeBSD.org> References: <1140487656.847.6.camel@synergy.odyssey.homeunix.org> <43FA7D9F.5090108@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-KL2WdFBfhaMnO2kavOUV" Organization: MarcusCom, Inc. Date: Mon, 20 Feb 2006 21:53:49 -0500 Message-Id: <1140490429.65763.3.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Cc: gnome@freebsd.org Subject: Re: Eog Crash while opening jpeg-images with EXIF data X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2006 02:53:57 -0000 --=-KL2WdFBfhaMnO2kavOUV Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2006-02-21 at 11:40 +0900, Alexander Nedotsukov wrote: > Pascal, > Cast it to (char*) instead. And this is not the only place in that file.=20 > You have to patch other memcpy()s too. I think guchar * would be more apt, no? Joe > All the best, > Alexander. > Pascal Hofstee wrote: > > i am noticing a consistent eog crash when opening jpeg images with EXIF > > data (using MC-gnome, eog-2.13.91) on FreeBSD/amd64 7.0-CURRENT > > > > The line that causes the crash is libeog/eog-metadata-reader.c:231 > > > > memcpy ((void*) ((int)(priv->exif_chunk) + priv->bytes_read), > > (void*)&buf[i], priv->size); > > > > I am about 99% sure the (int) typecast on priv->exit_chunk is truncatin= g > > the 64-bit pointer into 32-bits causing the application to segfault as = a > > result. I am not 100% on how to properly fix this. > > > > If any of you could have a look at this, that would be appreciated. > > > > =20 >=20 > _______________________________________________ > freebsd-gnome@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-gnome > To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@freebsd.org" >=20 --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-KL2WdFBfhaMnO2kavOUV Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (FreeBSD) iD8DBQBD+oC9b2iPiv4Uz4cRAmu7AJ9YelUhT7bxERhJwzjh5E5EEbWwkQCfQi+J wtgyUzQ6YOiSLNGcV3C18hg= =rUCo -----END PGP SIGNATURE----- --=-KL2WdFBfhaMnO2kavOUV--