Date: Tue, 21 Jun 2011 23:09:23 +0200 From: Attilio Rao <attilio@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: Alan Cox <alc@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r223307 - head/sys/vm Message-ID: <BANLkTi=7WnYPQRwE4Hi472DuJz91d1sK=g@mail.gmail.com> In-Reply-To: <20110622063258.D2275@besplex.bde.org> References: <201106191913.p5JJDOqJ006272@svn.freebsd.org> <BBC34F79-FFA7-4A05-83B3-DE17E0AB14D0@FreeBSD.org> <20110622063258.D2275@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/6/21 Bruce Evans <brde@optusnet.com.au>: > On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: > >> On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: >> >> Hi Alan, >> >>> Author: alc >>> Date: Sun Jun 19 19:13:24 2011 >>> New Revision: 223307 >>> URL: http://svn.freebsd.org/changeset/base/223307 >>> >>> Log: >>> =C2=A0Precisely document the synchronization rules for the page's dirty= field. >>> =C2=A0(Saying that the lock on the object that the page belongs to must= be >>> held >>> =C2=A0only represents one aspect of the rules.) >>> >>> =C2=A0Eliminate the use of the page queues lock for atomically performi= ng >>> read- >>> =C2=A0modify-write operations on the dirty field when the underlying >>> architecture >>> =C2=A0supports atomic operations on char and short types. >>> >>> =C2=A0Document the fact that 32KB pages aren't really supported. >> >> contrary to the tinderbox I'd like to point out that all mips kernels >> built by universe are broken with a SVN HEAD from earlier today. =C2=A0C= ould you >> please check and see if you can fix it? =C2=A0The errors I get are: >> >> vm_page.o: In function `vm_page_clear_dirty': >> /sys/vm/vm_page.c:(.text+0x18d0): undefined reference to `atomic_clear_8= ' >> /sys/vm/vm_page.c:(.text+0x18d0): relocation truncated to fit: R_MIPS_26 >> against `atomic_clear_8' >> vm_page.o: In function `vm_page_set_validclean': >> /sys/vm/vm_page.c:(.text+0x38f0): undefined reference to `atomic_clear_8= ' >> /sys/vm/vm_page.c:(.text+0x38f0): relocation truncated to fit: R_MIPS_26 >> against `atomic_clear_8' > > Atomic types shorter than int cannot be used in MI code, since they might > not exist. =C2=A0Apparently they don't exist on mips. =C2=A0jake@ fixed a= ll their > old uses for sparc4 in ~Y2K. I'm sure they do, they exist in support.S though and may not have the _8 form (they may just have the _char version). I may look at the code again to be sure. Attilio --=20 Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTi=7WnYPQRwE4Hi472DuJz91d1sK=g>