From owner-freebsd-perl@FreeBSD.ORG Wed Jan 21 07:05:04 2004 Return-Path: Delivered-To: freebsd-perl@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9BC216A4CE; Wed, 21 Jan 2004 07:05:04 -0800 (PST) Received: from mail.3wgraphics.net (mail.3wgraphics.net [194.87.91.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5ADC543D5A; Wed, 21 Jan 2004 07:04:50 -0800 (PST) (envelope-from skv@protey.ru) Received: from [192.168.0.1] (helo=protey.ru) by mail.3wgraphics.net with esmtp (Exim 4.24; FreeBSD) id 1AjJwY-000DyN-HW; Wed, 21 Jan 2004 18:06:58 +0300 Message-ID: <400E9591.8040109@protey.ru> Date: Wed, 21 Jan 2004 18:06:57 +0300 From: Sergey Skvortsov Organization: 3W Graphics User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 X-Accept-Language: en,ru MIME-Version: 1.0 To: Mathieu Arnold , perl@FreeBSD.org References: <400D4EE6.8010003@FreeBSD.org> <447910631.1074622626@andromede.reaumur.absolight.net> <400E4909.5020309@FreeBSD.org> <5310937.1074682561@pouet.in.mat.cc> In-Reply-To: <5310937.1074682561@pouet.in.mat.cc> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "freebsd.3wgraphics.net", hasmessageblock similar future email. If you have any questions, see the administrator of that system for details.bits that are in > |> > |> devel/p5-Module-Build/inc.build.mk > | > | Tedious to include. > > Well, I meant just put what's in there in bsd.port.mk :) I know it's not > easy to use :) [...] Content analysis details: (0.0 points, 5.0 required) pts rule name description -------------------------------------------------- Subject: Re: requst for review: PR/61621 X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2004 15:05:05 -0000 Mathieu Arnold wrote: > |> Why not reuse only the bits that are in > |> > |> devel/p5-Module-Build/inc.build.mk > | > | Tedious to include. > > Well, I meant just put what's in there in bsd.port.mk :) I know it's not > easy to use :) All of your include file is used in this patch. But this is not sufficient. > |> They are the only ones needed, and I've not seen yet a modules that only > |> comes with only a Build.PL and no passthrough Makefile.PL. > | > | There is no guarantee. > | And I suppose building modules via Module::Build has some advantages. > > Well, the Makefile.PL are just passthrough that run perl Build.PL, and > generate a makefile that will call perl Build. When I started with M::B, I > redefined do-build and do-install... But I felt it easier to maintain to > just use the passthrough Makefile. You're right, there is no guarantee that > it will always be, but it has been so far :) This patch is intended to naturally support Module::Build-driven ports. The next step - move all perl-related stuff into bsd.perl.mk. So the minimization of handling logic is not so important. And all new logic also will be moved into new .mk > And you should define ALL_TARGET?= build so that it has a resonable default > I guess. Empty target also works. > And, you'll have to account for M::B build process, it should use > PERL_MODBUILD=yes, but it should not depend on M::B, or it'll kinda loop :) p5-Module-Build should use usual "PERL_CONFIGURE" and redefine do-(build|install). Special check for portname 'p5-Module-Build' in bsd.port.mk is overkill and must be avoided. -- Sergey Skvortsov mailto: skv@protey.ru