From owner-cvs-all Fri Dec 27 16:41:25 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CC1E37B405; Fri, 27 Dec 2002 16:41:24 -0800 (PST) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0623A43ED4; Fri, 27 Dec 2002 16:41:24 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id B4E662A7EA; Fri, 27 Dec 2002 16:41:20 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: David O'Brien , Bruce Evans , Warner Losh , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/boot2 boot2.c In-Reply-To: <20021224024817.GA16364@dragon.nuxi.com> Date: Fri, 27 Dec 2002 16:41:20 -0800 From: Peter Wemm Message-Id: <20021228004120.B4E662A7EA@canning.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "David O'Brien" wrote: > On Sun, Dec 22, 2002 at 09:46:21AM +1100, Bruce Evans wrote: > > > > Modified files: > > > > sys/boot/i386/boot2 boot2.c > > > > Log: > > > > Put back the casts to unsigned. > > > Why is this not a back out of my rev 1.57 of only 5 days ago. Shouldn't > > > you have asked me to back it out instead?? > > > > I asked you to (by pointing out the bug), but received no response after > > 3-4 days. The commit that introduced the bug has several other changes. > > Like Imp [originally], I also didn't see the need for the casts. When I orinally removed them, it was because I was experimenting with changing large blocks to unsigned char *, and ended up backing them out since it was a space loss. I accidently backed out the strcmp ones as well, and never bothered to fix it. That change seems to have snuck into other prople's diffs. As far as calling it strcmp or not.. I dont see how its any different to us calling the mini-printf function printf() or not, it leaves out large chunks of the standard printf functionality. We are compiling with -ffreestanding for a reason.. because we're not running in a standard c-library environment. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message