From owner-freebsd-java@FreeBSD.ORG Tue Dec 20 19:26:22 2011 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0F641065675 for ; Tue, 20 Dec 2011 19:26:22 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id B519D8FC1E for ; Tue, 20 Dec 2011 19:26:22 +0000 (UTC) Received: by iadj38 with SMTP id j38so9978394iad.13 for ; Tue, 20 Dec 2011 11:26:22 -0800 (PST) Received: by 10.42.150.130 with SMTP id a2mr2989725icw.43.1324409182123; Tue, 20 Dec 2011 11:26:22 -0800 (PST) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id g34sm7920922ibk.10.2011.12.20.11.26.20 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Dec 2011 11:26:21 -0800 (PST) Sender: Jason Helfman Date: Tue, 20 Dec 2011 11:25:49 -0800 From: Jason Helfman To: Greg Lewis Message-ID: <20111220192549.GA58911@dormouse.experts-exchange.com> References: <201112201750.pBKHoD7P060916@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; x-action=pgp-signed In-Reply-To: <201112201750.pBKHoD7P060916@freefall.freebsd.org> X-Operating-System: FreeBSD 8.2-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-java@FreeBSD.org Subject: Re: java/163456: [patch] java/openjdk6: build and distribute open timezone data (tzdata) X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2011 19:26:23 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, Dec 20, 2011 at 05:50:13PM +0000, Greg Lewis thus spake: > Thanks for doing this! I wonder if with a little more work we couldn't > make this work for all of the JDK ports instead of having to reimplement > it for openjdk7, jdk16, jdk15, diablo, etc. Yeah, I suppose this could be done, and sounds fitting. I haven't researched it enough for all jdk implementations, however it going into openjdk{6,7}, at a minimum is a good start, in my opinion, until a more lucrative method is found. I couldn't believe that the timezone data hasn't been updated in openjdk6 since 2010, and I believe supplying at least updated zoneinfo is something we should consider. > I.e., can we pull this out into a separate port that installs the > appropriate zoneinfo files into somewhere like > ${LOCALBASE}/share/java/zoneinfo and then symlink the zi directory in all > of the jdk and jre ports to that directory. Installation of the zoneinfo files isn't the key, though. It is the raw timezone files that are required so java can build against them. But if those were built against then installed for java, that could work. > > I haven't looked deeply into your change but I assume the biggest problem > with this is that you need a JDK with javazic.jar already installed before > you can process the raw zoneinfo files so we'd be creating a circular > dependency. You don't need it installed. You can use the tool at build-time. My patch uses the ${WRKSRC} built bin/java and javazic.jar tool to build the zone files. It puts them into their new working directory, and they are installed with the install target. Hope this explains things a little more clearly. - -jgh - -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iQEcBAEBAgAGBQJO8OE9AAoJECBZmmNBUNPcSucH+gNbdBWQ9qpQTryvt2N4+Cqv ZSFjgZRaDcYUtNH2SNUS+aK8qTGWy6d/fKtkREZwe/2OS8AT8Ptg+2qSkRS/d+P2 ymKPvqzxBnU8QjZSGqW2bHckWR01UUkpFo23RD66wk/KvcfOTYQlMMHCVKpI5mVG kNbYH4r9wFEjkzS0TNboGiDOZ8kZEmWwnyGGQqIjYZM2MKc5SsnRhaW2WYwYGuEH O65y/ePjr4QAY6WLVFYijYEiguieErJWu514KqRQiB7QVoc9aBcaXzMUW9mzSpjg Cnk2iqBfdCmUZ7r3WBa3cKRjYWtOKlR/6JUlqKTUA662BWV7tlEDoXhml/VjxoI= =3UgU -----END PGP SIGNATURE-----