From owner-freebsd-fs@FreeBSD.ORG Thu Apr 29 06:56:56 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9FFF9106564A; Thu, 29 Apr 2010 06:56:56 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com [209.85.218.216]) by mx1.freebsd.org (Postfix) with ESMTP id C4E758FC0C; Thu, 29 Apr 2010 06:56:55 +0000 (UTC) Received: by bwz8 with SMTP id 8so14013798bwz.3 for ; Wed, 28 Apr 2010 23:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject :organization:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=r22CazZ7us2IYtb97UdZrHyxMp1IBwHoqLg2o8Ha1Kg=; b=MVuIByxbNM3x59Ei9CX159enYgUqDbHIok+30sPIo737I10Zcu0hpNToDRr7RwWeCO F8HhyxW+rfRibRC0s0iQIgU4L1PLj906ca8MXxDyfvp7yAdhZOHqkb5MRKqbJqIDuFAM 8M5z2Vop9FRsd7kNuL1q3gCgbfbx42eTuP46c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=cmWSpYm2N+WuGbarrjkGSo/VDvH74kLsPXaNYzMQ9qyeyy+tahMa67DcL9Yx/wFK0v jFkEKsdmAShRwotqurVpyxjfdUjdW8rb66mxgi3AH6oQEXZL0SHy+sQ/zCddCKH+8XGH U91SMhAa71rWcJmz6DDK5hcpkhLZBDTK/cp6Y= Received: by 10.204.74.98 with SMTP id t34mr1074443bkj.154.1272524207743; Wed, 28 Apr 2010 23:56:47 -0700 (PDT) Received: from localhost (ua1.etadirect.net [91.198.140.16]) by mx.google.com with ESMTPS id 16sm193725bwz.5.2010.04.28.23.56.46 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 28 Apr 2010 23:56:46 -0700 (PDT) From: Mikolaj Golub To: Pawel Jakub Dawidek Organization: TOA Ukraine References: <86iq7ex9j0.fsf@kopusha.onet> <20100428224326.GE1677@garage.freebsd.pl> Date: Thu, 29 Apr 2010 09:56:44 +0300 In-Reply-To: <20100428224326.GE1677@garage.freebsd.pl> (Pawel Jakub Dawidek's message of "Thu, 29 Apr 2010 00:43:26 +0200") Message-ID: <86r5lykaqb.fsf@zhuzha.ua1> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-fs Subject: Re: hastd segfaults reading metadata from not initialized provider X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2010 06:56:56 -0000 On Thu, 29 Apr 2010 00:43:26 +0200 Pawel Jakub Dawidek wrote: PJD> On Mon, Apr 26, 2010 at 11:07:31PM +0300, Mikolaj Golub wrote: >> Hi, >> >> When configuring a new provider if one forgets to do >> >> hastctl create tank >> >> before >> >> hastctl role primary tank PJD> In my tests I cannot reproduce it. If metadata is empty hastd should PJD> notice that, but check for NULL was missing anyway. I observe this on VirtualBox hosts with virtual disks (dynamically expanding storage). PJD> I fixed it a bit different. In general nv API is constructued in a way PJD> that the consumer might execute various calls and check for error at the PJD> end. This is what we do there already, only (str != NULL) check was PJD> missing. Thanks for the report, I committed fix to HEAD. Thank you :-) -- Mikolaj Golub