From owner-svn-src-head@FreeBSD.ORG Wed Apr 8 19:55:24 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C483DED8; Wed, 8 Apr 2015 19:55:24 +0000 (UTC) Received: from mail-wg0-x235.google.com (mail-wg0-x235.google.com [IPv6:2a00:1450:400c:c00::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 550C5F8E; Wed, 8 Apr 2015 19:55:24 +0000 (UTC) Received: by wgin8 with SMTP id n8so99399769wgi.0; Wed, 08 Apr 2015 12:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=YTqg1s2NMDZCjFNSdU4eEfnuoTZNK0vAHeJ1JD9ad0k=; b=kd1J5BT53oSZc5WU+6Wn8QBvBJhUmm1V4i84hNxe3CMO6gG2bnA0jLxiu/o9WLv3dE jfGlzknJBmBHX+QlMkBplzHajTU/k598H+kgHZrmA/pIfqOaqfgrAaKW9nVvjbqNFyRx 5Mht0REPy7smmEGE0idPtYeJIVxJNmOVmm9Gzu2FEjtNq/IL/BJvm025FuHMAGv+GQ+A HeLs5mkimFDrgh8iPEFZaZ79USijeqqLDDm2yZQVdjU+hEi3dikx7CHyZZjTwPYA6UQD C0LtoeG9LsSSGwxd9QHyH+ze7GLWDQxSveEeHzNxJi2g950+JOObQBp7/YOhRukapIYg 5UqA== X-Received: by 10.194.200.194 with SMTP id ju2mr45286965wjc.61.1428522922368; Wed, 08 Apr 2015 12:55:22 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id ev7sm16987236wjb.47.2015.04.08.12.55.20 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 08 Apr 2015 12:55:21 -0700 (PDT) Date: Wed, 8 Apr 2015 21:55:18 +0200 From: Mateusz Guzik To: Chagin Dmitry Subject: Re: svn commit: r281113 - head/sys/vm Message-ID: <20150408195518.GA6086@dft-labs.eu> References: <201504051825.t35IPO7t078390@svn.freebsd.org> <20150405183947.GA24293@dft-labs.eu> <20150405185419.GA46092@dchagin.static.corbina.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150405185419.GA46092@dchagin.static.corbina.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2015 19:55:25 -0000 On Sun, Apr 05, 2015 at 09:54:19PM +0300, Chagin Dmitry wrote: > On Sun, Apr 05, 2015 at 08:39:47PM +0200, Mateusz Guzik wrote: > > On Sun, Apr 05, 2015 at 06:25:24PM +0000, Dmitry Chagin wrote: > > > Author: dchagin > > > Date: Sun Apr 5 18:25:23 2015 > > > New Revision: 281113 > > > URL: https://svnweb.freebsd.org/changeset/base/281113 > > > > > > Log: > > > Fix wrong kassert msg in uma. > > > > > > PR: 199172 > > > Submitted by: luke.tw gmail com > > > MFC after: 1 week > > > > > > Modified: > > > head/sys/vm/uma_core.c > > > > > > Modified: head/sys/vm/uma_core.c > > > ============================================================================== > > > --- head/sys/vm/uma_core.c Sun Apr 5 17:09:58 2015 (r281112) > > > +++ head/sys/vm/uma_core.c Sun Apr 5 18:25:23 2015 (r281113) > > > @@ -3060,7 +3060,7 @@ uma_zone_set_fini(uma_zone_t zone, uma_f > > > uma_keg_t keg; > > > > > > keg = zone_first_keg(zone); > > > - KASSERT(keg != NULL, ("uma_zone_set_init: Invalid zone type")); > > > + KASSERT(keg != NULL, ("uma_zone_set_fini: Invalid zone type")); > > > KEG_LOCK(keg); > > > KASSERT(keg->uk_pages == 0, > > > ("uma_zone_set_fini on non-empty keg")); > > > @@ -3100,7 +3100,7 @@ uma_zone_set_freef(uma_zone_t zone, uma_ > > > uma_keg_t keg; > > > > > > keg = zone_first_keg(zone); > > > - KASSERT(keg != NULL, ("uma_zone_set_init: Invalid zone type")); > > > + KASSERT(keg != NULL, ("uma_zone_set_freef: Invalid zone type")); > > > KEG_LOCK(keg); > > > keg->uk_freef = freef; > > > KEG_UNLOCK(keg); > > > > > > > This seems to be a recurring problem (go figure). > > > > Was __func__ usage flamed over? > > > > I really think that linux's oops-like dump would be of great help here. > > It includes file + line info along with register dump which alone can > > give sufficient hints in several cases. > > > finally, kassert prints backtrace. also feel free to set > debug.kassert.do_kdb. The point is to have initial user reports more useful. As it is, with mere panic message there is not much to work with. -- Mateusz Guzik