From owner-svn-src-head@freebsd.org Tue Sep 22 23:17:32 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BA8C63E3B77; Tue, 22 Sep 2020 23:17:32 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bwxzc4W7jz3bWj; Tue, 22 Sep 2020 23:17:32 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 79B461FA4E; Tue, 22 Sep 2020 23:17:32 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f178.google.com with SMTP id o5so20953582qke.12; Tue, 22 Sep 2020 16:17:32 -0700 (PDT) X-Gm-Message-State: AOAM532Jb3rdEBalTWqQeEc2ULCYh93UdZZFyL7Sayb4qoi7/p38tN1r 9J+P60JRgcHt9NFqyRjCpb3buCvPSGjOweUgMVw= X-Google-Smtp-Source: ABdhPJzbBlEf2812x7C9uWGvjaOMA1K810u3nfXWAaScuWwWkelqxdaSTSNC7/f/JSOktmNWpS7qM3qWtjK8p1Ervwo= X-Received: by 2002:a05:620a:4fb:: with SMTP id b27mr7721037qkh.120.1600816652148; Tue, 22 Sep 2020 16:17:32 -0700 (PDT) MIME-Version: 1.0 References: <202009112049.08BKnavL032212@repo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Tue, 22 Sep 2020 18:17:20 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r365643 - head/bin/cp To: Warner Losh Cc: Ian Lepore , Alan Somers , Mateusz Guzik , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2020 23:17:32 -0000 On Tue, Sep 22, 2020, 17:02 Warner Losh wrote: > > > On Tue, Sep 22, 2020 at 3:55 PM Kyle Evans wrote: > >> On Tue, Sep 22, 2020 at 4:53 PM Ian Lepore wrote: >> > >> > On Tue, 2020-09-22 at 15:50 -0600, Warner Losh wrote: >> > > I think it's a great leap sideways, but I've done cp /dev/null foo to >> > > clear >> > > it out for 35 years now... It's why it feels like a workaround. >> > > >> > > Though it is a legit optimization, no matter the feelings. As for >> > > clearer, >> > > I'm less sure since then I have to remember what the : operator does. >> > > >> > > Warner >> > > >> > >> > For me, :> is idiomatic (but ugly). >> > >> > On the other hand, the cp /dev/null had a nice dogfooding aspect to >> > it... when we broke cp by accident, its use in the build system was the >> > first alarm to go off. >> > >> > --Ian >> > >> >> To be honest, this is a case that really should be covered by >> regression tests somewhere. >> > > It should (but isn't yet). > > Ian is right for old-school FreeBSD thinking. In that thinking the build > system should use an eclectic mix of tools to act as a fire-wall against > accidental breakage. > > Complete, effective, test suites give much better coverage... if they are > run... > > So until we run tests frequently, with loud regression squawking that's as > effective as build breakage, I tend to fall in the 'all of the above' camp > until that's in place... :) > > Warner > > P.S. though not, if I suppose, if it means that we're slowing down the > regression coverage uptake... > -- The test build was fine, please confirm if I can commit it or if someone else would like to write the UPDATING notice or start bootstrapping cp on systems that were affected. I'm not comfortable with not taking any path at all here, but this is a lot of friction for a small mechanical change to ease the pain. Thanks, Kyle Evans >