From owner-freebsd-current@FreeBSD.ORG Fri Nov 18 19:05:20 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1584D16A43D for ; Fri, 18 Nov 2005 19:05:20 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from sccrmhc14.comcast.net (sccrmhc14.comcast.net [204.127.202.59]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3A5D43DAB for ; Fri, 18 Nov 2005 19:04:50 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-66-30-114-245.hsd1.ma.comcast.net ([66.30.114.245]) by comcast.net (sccrmhc14) with ESMTP id <2005111819044901400lq6fhe>; Fri, 18 Nov 2005 19:04:49 +0000 Received: from c-66-30-114-245.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-66-30-114-245.hsd1.ma.comcast.net (8.13.4/8.13.1) with ESMTP id jAIJ4nCW006879; Fri, 18 Nov 2005 14:04:49 -0500 (EST) (envelope-from rodrigc@c-66-30-114-245.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-66-30-114-245.hsd1.ma.comcast.net (8.13.4/8.13.1/Submit) id jAIJ4mJU006878; Fri, 18 Nov 2005 14:04:48 -0500 (EST) (envelope-from rodrigc) Date: Fri, 18 Nov 2005 14:04:48 -0500 From: Craig Rodrigues To: Rainer Hurling Message-ID: <20051118190448.GA6870@crodrigues.org> References: <437E1477.7030902@gwdg.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <437E1477.7030902@gwdg.de> User-Agent: Mutt/1.4.2.1i Cc: freebsd-current@freebsd.org Subject: Re: mount_msdosfs and longnames X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2005 19:05:20 -0000 On Fri, Nov 18, 2005 at 06:50:47PM +0100, Rainer Hurling wrote: > Looking in /usr/src/sys/fs/msdosfs/msdosfs_vfsops.c [Version 1.147 from > 2005/10/31 15:41:20] there is a naming discrepancy against the manpage: > supported options are 'shortname' and 'longname' without s. I hope I did > not misunderstood this. There was a naming discrepancy between the userland mount_msdosfs utility, and the implementation of the option in the msdos_vfsops.c for quite a while which was hidden in the mess of the old mount code. When I converted mount_msdosfs to use nmount(), this discrepancy was uncovered. Can you try this patch? Index: msdosfs_vfsops.c =================================================================== RCS file: /home/ncvs/src/sys/fs/msdosfs/msdosfs_vfsops.c,v retrieving revision 1.147 diff -u -u -r1.147 msdosfs_vfsops.c --- msdosfs_vfsops.c 31 Oct 2005 15:41:20 -0000 1.147 +++ msdosfs_vfsops.c 18 Nov 2005 19:02:40 -0000 @@ -81,7 +81,7 @@ "from", "export", "uid", "gid", "mask", "dirmask", - "shortname", "longname", "win95", + "shortname", "shortnames", "longname", "longnames", "win95", "kiconv", "cs_win", "cs_dos", "cs_local", NULL }; @@ -163,8 +163,12 @@ pmp->pm_dirmask = v & ALLPERMS; vfs_flagopt(mp->mnt_optnew, "shortname", &pmp->pm_flags, MSDOSFSMNT_SHORTNAME); + vfs_flagopt(mp->mnt_optnew, "shortnames", + &pmp->pm_flags, MSDOSFSMNT_SHORTNAME); vfs_flagopt(mp->mnt_optnew, "longname", &pmp->pm_flags, MSDOSFSMNT_LONGNAME); + vfs_flagopt(mp->mnt_optnew, "longnames", + &pmp->pm_flags, MSDOSFSMNT_LONGNAME); vfs_flagopt(mp->mnt_optnew, "kiconv", &pmp->pm_flags, MSDOSFSMNT_KICONV); -- Craig Rodrigues rodrigc@crodrigues.org