From owner-svn-src-head@freebsd.org  Wed Aug  2 11:14:02 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 089D2DCD8BB;
 Wed,  2 Aug 2017 11:14:02 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C7225EAF;
 Wed,  2 Aug 2017 11:14:01 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id D9837260179;
 Wed,  2 Aug 2017 13:13:58 +0200 (CEST)
Subject: Re: svn commit: r321920 - head/sys/sys
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201708021014.v72AEHEk061037@repo.freebsd.org>
 <7b1d274f-a531-f788-742a-a8375fe76763@selasky.org>
 <20170802110607.GC1700@kib.kiev.ua>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <760e0077-499e-fffb-a86b-979e410b35e1@selasky.org>
Date: Wed, 2 Aug 2017 13:11:48 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20170802110607.GC1700@kib.kiev.ua>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 11:14:02 -0000

On 08/02/17 13:06, Konstantin Belousov wrote:
> So linuxkpi was broken before this commit as well, as I noted in my
> other reply ?

Hi,

The LinuxKPI uses minor/major/makedev internally.

y = makedev(z,t)

Then the LinuxKPI assumes z and t can be retrieved through minor and 
major: minor(y) == z and major(y) == t

If "y" is an "int" and it is assigned a 64-bit value, it is obvious that 
this code no longer holds true. Same might be in userspace/ports.

So yes, this change breaks the LinuxKPI, at least some parts of it.

--HPS