From owner-freebsd-arch@FreeBSD.ORG  Tue Jun 26 20:28:33 2012
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BAF47106564A
	for <freebsd-arch@freebsd.org>; Tue, 26 Jun 2012 20:28:33 +0000 (UTC)
	(envelope-from sjg@juniper.net)
Received: from exprod7og102.obsmtp.com (exprod7og102.obsmtp.com [64.18.2.157])
	by mx1.freebsd.org (Postfix) with ESMTP id 5FF3B8FC0A
	for <freebsd-arch@freebsd.org>; Tue, 26 Jun 2012 20:28:33 +0000 (UTC)
Received: from P-EMHUB03-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by
	exprod7ob102.postini.com ([64.18.6.12]) with SMTP
	ID DSNKT+obcS6crLAZAY6vK028SAr7857FAGFz@postini.com;
	Tue, 26 Jun 2012 13:28:33 PDT
Received: from magenta.juniper.net (172.17.27.123) by P-EMHUB03-HQ.jnpr.net
	(172.24.192.33) with Microsoft SMTP Server (TLS) id 8.3.213.0;
	Tue, 26 Jun 2012 13:24:53 -0700
Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229])	by
	magenta.juniper.net (8.11.3/8.11.3) with ESMTP id q5QKOqh77601;
	Tue, 26 Jun 2012 13:24:52 -0700 (PDT)	(envelope-from sjg@juniper.net)
Received: from chaos.jnpr.net (localhost [127.0.0.1])	by chaos.jnpr.net
	(Postfix) with ESMTP id 3028158081;
	Tue, 26 Jun 2012 13:24:52 -0700 (PDT)
To: Eric van Gyzen <eric@vangyzen.net>
In-Reply-To: <4FEA10BD.2080504@vangyzen.net>
References: <20120626063017.D05DA58081@chaos.jnpr.net>
	<86wr2uwdgf.fsf@ds4.des.no>
	<CAGE5yCobmB6PyCzqSxVgbBomuE7AHWmUd5e4pEqHNeFvxpZCAQ@mail.gmail.com>
	<CAGE5yCqy5bRoNNDc_4hK9wtvVxEzoQrjNvGyLOvJy2VZAF=tZw@mail.gmail.com>
	<20120626190349.98D5B58081@chaos.jnpr.net>
	<97FE8A0B-1836-4C60-9086-9C30A1123CE9@bsdimp.com>
	<4FEA10BD.2080504@vangyzen.net>
Comments: In-reply-to: Eric van Gyzen <eric@vangyzen.net>
	message dated "Tue, 26 Jun 2012 14:42:53 -0500."
From: "Simon J. Gerraty" <sjg@juniper.net>
X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1
Date: Tue, 26 Jun 2012 13:24:52 -0700
Message-ID: <20120626202452.3028158081@chaos.jnpr.net>
MIME-Version: 1.0
Content-Type: text/plain
Cc: =?ISO-8859-1?Q?rgrav?= <des@des.no>, =?ISO-8859-1?Q?Dag-Erling_Sm=F8?=,
	Warner Losh <wlosh@bsdimp.com>, freebsd-arch@freebsd.org
Subject: Re: Allow user install
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2012 20:28:33 -0000


On Tue, 26 Jun 2012 14:42:53 -0500, Eric van Gyzen writes:
>>>
>>> +_uid!= id -u
>>> +.if ${MK_INSTALL_AS_USER} != "no"&&  ${_uid} != 0
>>> +_gid!= id -g
>>> +.for x in BIN CONF DOC INFO KMOD LIB MAN NLS SHARE
>>> +$xOWN = ${_uid}
>>> +$xGRP = ${_gid}

>> I like this a lot more.
>
>Me too.  We're doing almost exactly that, directly in make.conf.  Yours 
>is cleaner, of course.

A final? tweak, I've moved the _uid!= id -u inside the first .if and
added another to avoid id -u if MK_INSTALL_AS_USER==no, the extra .if is
much cheaper than running 'id'.

+.if ${MK_INSTALL_AS_USER} != "no"
+_uid!= id -u
+.if ${_uid} != 0
+_gid!= id -g
+.for x in BIN CONF DOC INFO KMOD LIB MAN NLS SHARE
+$xOWN= ${_uid}
+$xGRP= ${_gid}