From owner-freebsd-hackers@FreeBSD.ORG  Fri Nov  5 20:01:09 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2E54C106567A;
	Fri,  5 Nov 2010 20:01:09 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107])
	by mx1.freebsd.org (Postfix) with ESMTP id BFAAA8FC1C;
	Fri,  5 Nov 2010 20:01:08 +0000 (UTC)
Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132])
	by mx1.stack.nl (Postfix) with ESMTP id D0C781DD753;
	Fri,  5 Nov 2010 21:01:07 +0100 (CET)
Received: by turtle.stack.nl (Postfix, from userid 1677)
	id C65FD17315; Fri,  5 Nov 2010 21:01:07 +0100 (CET)
Date: Fri, 5 Nov 2010 21:01:07 +0100
From: Jilles Tjoelker <jilles@stack.nl>
To: Baptiste Daroussin <bapt@freebsd.org>
Message-ID: <20101105200107.GB84851@stack.nl>
References: <AANLkTi=vxnbFvJabRYLKXG1zA5ry=Phh7y+kg7wjvFmr@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTi=vxnbFvJabRYLKXG1zA5ry=Phh7y+kg7wjvFmr@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-hackers@freebsd.org
Subject: Re: [PATCH] update to the latest libedit version and remove
 libreadline deps
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Nov 2010 20:01:09 -0000

On Fri, Nov 05, 2010 at 04:32:56PM +0100, Baptiste Daroussin wrote:
> I've updated libedit to the latest version available in the netbsd cvs.
> UTF8 support is disabled for now has it seems to be experimental and segfault.
> I also patch and tested all the sources that used to be linked against
> libreadline so that it now uses libedit making libreadline unused (I
> guess, perhaps I have missed some)

> beware that there are collision between libreadline and libedit
> (/usr/include/readline/readline.h) is provided by both of them.

> You can find the patch against current here:
> http://people.freebsd.org/~bapt/update-libedit.patch

This patch reverts various local enhancements to libedit, such as:
* r212191 more expected behaviour of ed-delete-next-char
* r212235 <delete> key support
* r209217,r209219,r209224 completion improvements for sh(1)
* built-in "\033[1~" and "\033[4~" support (not sure how useful this is)
* .An macros in man pages

If the csh-style history expansion gets in, a "set -o histexpand" for sh
could be useful. I think this is not important enough to add all the
code for, but if we have the code anyway why not allow using it. On the
other hand, if we can replace it with stubs and is very simplistic,
perhaps it is better to stub it out and not change sh.

-- 
Jilles Tjoelker