From owner-freebsd-current Wed Jan 5 23:50:32 2000 Delivered-To: freebsd-current@freebsd.org Received: from freebsd.dk (freebsd.dk [212.242.42.178]) by hub.freebsd.org (Postfix) with ESMTP id DDAAB14F85; Wed, 5 Jan 2000 23:50:13 -0800 (PST) (envelope-from sos@freebsd.dk) Received: (from sos@localhost) by freebsd.dk (8.9.3/8.9.1) id IAA73510; Thu, 6 Jan 2000 08:50:07 +0100 (CET) (envelope-from sos) From: Soren Schmidt Message-Id: <200001060750.IAA73510@freebsd.dk> Subject: Re: ATA atapi-all.c problems/fixes/cleanups In-Reply-To: from Brian Fundakowski Feldman at "Jan 5, 2000 06:50:45 pm" To: green@FreeBSD.org (Brian Fundakowski Feldman) Date: Thu, 6 Jan 2000 08:50:07 +0100 (CET) Cc: current@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG It seems Brian Fundakowski Feldman wrote: > How about this? It's mostly the changes in your patch, but it also takes > into account non-int{8,16}_t-sizing/alignment. It also takes care of the > truncation problem when you use outsl and insl, as part of that. Please > review it, as I think it should be the right thing to do. Hmm, sortof. In the real world we should newer ever see partial transfers, they should always be of N * DEV_BSIZE, so this is a bitt overkill. However some of the internal ATAPI handling use odd sizes for modes etc, but they are all at least 16 bit aligned, so 8 bit alignment is not needed, I'll have to check if we need 16 bit alignment, I can't remember ofhand... -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message