From owner-svn-src-head@FreeBSD.ORG Wed Feb 11 14:50:16 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A8681065670; Wed, 11 Feb 2009 14:50:16 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id EF28A8FC19; Wed, 11 Feb 2009 14:50:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (pool-98-109-39-197.nwrknj.fios.verizon.net [98.109.39.197]) by cyrus.watson.org (Postfix) with ESMTPSA id 9A05346B52; Wed, 11 Feb 2009 09:50:15 -0500 (EST) Received: from localhost (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id n1BEo9F9025248; Wed, 11 Feb 2009 09:50:09 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Alexander Motin Date: Wed, 11 Feb 2009 08:29:20 -0500 User-Agent: KMail/1.9.7 References: <200902102322.n1ANMTgW007393@svn.freebsd.org> In-Reply-To: <200902102322.n1ANMTgW007393@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902110829.20859.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 11 Feb 2009 09:50:09 -0500 (EST) X-Virus-Scanned: ClamAV 0.94.2/8979/Wed Feb 11 07:23:15 2009 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r188464 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2009 14:50:16 -0000 On Tuesday 10 February 2009 6:22:29 pm Alexander Motin wrote: > Author: mav > Date: Tue Feb 10 23:22:29 2009 > New Revision: 188464 > URL: http://svn.freebsd.org/changeset/base/188464 > > Log: > Check for device_set_devclass() errors and skip driver probe/attach if any. > Attach call without devclass set crashes the system. > > On resume AHCI driver sometimes tries to create duplicate adX device. > It is surely his own problem, but IMHO it is not a reason to crash here. > Other reasons are also possible. Can you describe the problem a bit more fully? Is the ata driver adding a device with a fixed unit number but a wildcard class? (That is, it is doing something like 'device_add_child(dev, NULL, 4)'?) -- John Baldwin