From owner-svn-src-head@freebsd.org Wed Dec 16 16:15:54 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 115E5A49016; Wed, 16 Dec 2015 16:15:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E55B810E8; Wed, 16 Dec 2015 16:15:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 0424AB981; Wed, 16 Dec 2015 11:15:53 -0500 (EST) From: John Baldwin To: Randall Stewart Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292309 - in head/sys: modules modules/tcp modules/tcp/fastpath netinet netinet/tcp_stacks Date: Wed, 16 Dec 2015 07:06:31 -0800 Message-ID: <1972466.CRnu3P14jO@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201512160056.tBG0ujqA067178@repo.freebsd.org> References: <201512160056.tBG0ujqA067178@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 16 Dec 2015 11:15:53 -0500 (EST) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2015 16:15:54 -0000 On Wednesday, December 16, 2015 12:56:45 AM Randall Stewart wrote: > Author: rrs > Date: Wed Dec 16 00:56:45 2015 > New Revision: 292309 > URL: https://svnweb.freebsd.org/changeset/base/292309 > > Log: > First cut of the modularization of our TCP stack. Still > to do is to clean up the timer handling using the async-drain. > Other optimizations may be coming to go with this. Whats here > will allow differnet tcp implementations (one included). > Reviewed by: jtl, hiren, transports > Sponsored by: Netflix Inc. > Differential Revision: D4055 Have you considered treating TOE as a separate stack? We already have a bit of a split to handle TOE specially. It might be nice if it was able to plug in via this. That might also help flesh out the abstraction a bit by giving another use case. Also, note that the Differential Revision tag should be the full URL to the review (in which case it auto-closes it for you). -- John Baldwin