From owner-cvs-all@FreeBSD.ORG Thu Jul 21 20:35:15 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 665361065674; Thu, 21 Jul 2011 20:35:15 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 291D7163693; Thu, 21 Jul 2011 20:35:08 +0000 (UTC) Message-ID: <4E288D7C.1080403@FreeBSD.org> Date: Thu, 21 Jul 2011 13:35:08 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:5.0) Gecko/20110706 Thunderbird/5.0 MIME-Version: 1.0 To: Dimitry Andric References: <201107212018.p6LKIjm1023087@repoman.freebsd.org> In-Reply-To: <201107212018.p6LKIjm1023087@repoman.freebsd.org> X-Enigmail-Version: 1.2pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/libgcrypt/files patch-cipher-rijndael.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2011 20:35:15 -0000 Good catch! Was this submitted upstream? On 07/21/2011 13:18, Dimitry Andric wrote: > dim 2011-07-21 20:18:45 UTC > > FreeBSD ports repository (src committer) > > Added files: > security/libgcrypt/files patch-cipher-rijndael.c > Log: > Building security/libgcrypt 1.5.0 with clang results in errors similar > to the following: > > rijndael.c:846:46: error: ambiguous instructions require an explicit suffix (could be 'cmpb', 'cmpw', 'cmpl', or 'cmpq') > "movdqa 0xa0(%%esi), %%xmm1\n\t" > ^ > :24:2: note: instantiated into assembly here > cmp $10, -80(%ebp) > ^ > > This is because the 'cmp' instruction lacks a type suffix, and is thus > ambiguous. Fix this by changing these to 'cmpq'. > > PR: ports/158994 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=158994 > Approved by: Hirohisa Yamaguchi (maintainer) > > Revision Changes Path > 1.1 +61 -0 ports/security/libgcrypt/files/patch-cipher-rijndael.c (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/libgcrypt/files/patch-cipher-rijndael.c > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/