Date: Mon, 17 Aug 2020 13:23:43 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Ed Maste <emaste@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364321 - head/sbin/ipfw Message-ID: <202008172023.07HKNh1q061925@gndrsh.dnsmgr.net> In-Reply-To: <202008171853.07HIrNAC082123@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > Author: emaste > Date: Mon Aug 17 18:53:23 2020 > New Revision: 364321 > URL: https://svnweb.freebsd.org/changeset/base/364321 > > Log: > ipfw: line up `ipfw -t list` with and without timestamp > > From the PR: > When I run `ipfw -t list` on release/12 or current, I get misaligned > output between lines that do and do not have a last match timestamp, > like so: > > 00100 Tue Aug 11 03:03:26 2020 allow ip from any to any via lo0 > 00200 deny ip from any to 127.0.0.0/8 > > (specifically, the "allow" and "deny" strings do not line up) > > PR: 248608 > Submitted by: Taylor Stearns > MFC after: 3 days > > Modified: > head/sbin/ipfw/ipfw2.c > > Modified: head/sbin/ipfw/ipfw2.c > ============================================================================== > --- head/sbin/ipfw/ipfw2.c Mon Aug 17 17:48:28 2020 (r364320) > +++ head/sbin/ipfw/ipfw2.c Mon Aug 17 18:53:23 2020 (r364321) > @@ -2199,7 +2199,7 @@ show_static_rule(struct cmdline_opts *co, struct forma > *strchr(timestr, '\n') = '\0'; > bprintf(bp, "%s ", timestr); ^ Isnt this the +1 space? > } else { > - bprintf(bp, "%*s", twidth, " "); > + bprintf(bp, "%*s", twidth + 1, " "); ^missing from this string? > } > } > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008172023.07HKNh1q061925>