From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Jun 11 12:40:09 2008
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19A8110656AB
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Wed, 11 Jun 2008 12:40:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id EC5EB8FC3B
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Wed, 11 Jun 2008 12:40:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5BCe8oO034597
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Wed, 11 Jun 2008 12:40:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5BCe87q034596;
	Wed, 11 Jun 2008 12:40:08 GMT (envelope-from gnats)
Resent-Date: Wed, 11 Jun 2008 12:40:08 GMT
Resent-Message-Id: <200806111240.m5BCe87q034596@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ed Schouten <ed@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 316901065678
	for <FreeBSD-gnats-submit@freebsd.org>;
	Wed, 11 Jun 2008 12:35:40 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:610:652::211])
	by mx1.freebsd.org (Postfix) with ESMTP id EC3E18FC16
	for <FreeBSD-gnats-submit@freebsd.org>;
	Wed, 11 Jun 2008 12:35:39 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 55C321CC1A; Wed, 11 Jun 2008 14:33:04 +0200 (CEST)
Message-Id: <20080611123304.55C321CC1A@palm.hoeg.nl>
Date: Wed, 11 Jun 2008 14:33:04 +0200 (CEST)
From: Ed Schouten <ed@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Cc: 
Subject: ports/124485: [Patch] comms/conserver-com: don't use sgtty
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Ed Schouten <ed@FreeBSD.org>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jun 2008 12:40:09 -0000


>Number:         124485
>Category:       ports
>Synopsis:       [Patch] comms/conserver-com: don't use sgtty
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 11 12:40:08 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Ed Schouten
>Release:        FreeBSD 6.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD palm.hoeg.nl 6.3-STABLE FreeBSD 6.3-STABLE #0: Wed Jun 4 08:56:01 CEST 2008 ed@palm.hoeg.nl:/usr/obj/usr/src/sys/PALM i386
>Description:
The conserver-com port also needs a small change to compile properly
when sgtty is not available. On FreeBSD, TAB3 is called OXTABS.

See the PR about conserver for more details.
>How-To-Repeat:
>Fix:
--- conserver/group.c
+++ conserver/group.c
@@ -3839,12 +3839,10 @@
 					      "failed]\r\n", -1);
 				    continue;
 				}
-				if (TAB3 == (TABDLY & sbuf.c_oflag)) {
-				    sbuf.c_oflag &= ~TABDLY;
-				    sbuf.c_oflag |= TAB0;
+				if (sbuf.c_oflag & OXTABS) {
+					sbuf.c_oflag &= ~OXTABS;
 				} else {
-				    sbuf.c_oflag &= ~TABDLY;
-				    sbuf.c_oflag |= TAB3;
+					sbuf.c_oflag |= OXTABS;
 				}
 				if (-1 ==
 				    tcsetattr(FileFDNum
>Release-Note:
>Audit-Trail:
>Unformatted: