From owner-cvs-src@FreeBSD.ORG  Sat May 22 05:20:45 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C92AA16A4CE; Sat, 22 May 2004 05:20:45 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BCDF143D3F; Sat, 22 May 2004 05:20:45 -0700 (PDT)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id E2DDE5C85F; Sat, 22 May 2004 05:20:00 -0700 (PDT)
Date: Sat, 22 May 2004 14:20:00 +0200
From: Maxime Henrion <mux@freebsd.org>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20040522122000.GJ700@elvis.mu.org>
References: <200405181653.i4IGrU6g062365@repoman.freebsd.org>
	<200405211327.16382.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200405211327.16382.jhb@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: Nate Lawson <njl@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/acpica acpivar.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 May 2004 12:20:46 -0000

John Baldwin wrote:
> On Tuesday 18 May 2004 12:53 pm, Nate Lawson wrote:
> > njl         2004/05/18 09:53:29 PDT
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/dev/acpica       acpivar.h
> >   Log:
> >   Use the simpler __BUS_ACCESSOR macros for ivars instead of defining them
> >   ourselves.
> 
> This breaks probing of non-ACPI PCI busses.

I confirm this.  My system has one ACPI PCI bus and one non-ACPI PCI
bus.  With revision 1.65 of acpivar.h, my system panics when attaching
the non-ACPI PCI bus, trying to dereference NULL.  It works OK if I
rollbak to acpivar.h revision 1.64.

Cheers,
Maxime