From owner-svn-src-head@freebsd.org Wed Jul 8 22:34:35 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB362996BAB for ; Wed, 8 Jul 2015 22:34:35 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com [209.85.192.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C3E91C94 for ; Wed, 8 Jul 2015 22:34:35 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by pdbep18 with SMTP id ep18so152788446pdb.1 for ; Wed, 08 Jul 2015 15:34:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=yNydDeg2Zfab8Y4517CG1UbJ+QR2ldoO0u6BWtsbG4g=; b=Bj65eUIF5bR0yigdvP6xJodBywYKHivrtfkAHRqwESI0r6MVZFA876QhXVCMb9S0oq 36uYNbV6sU1WRfu+fJ84RjLYlUIkwkW3Fn/NzeJ81sBLC2i8cWYxmslRIlOMsFrQ0Vvg 7VW39tBJdbYDkIx/eit7u8H6NBfnyU3YZQc+BfMh8/NRKiWTdSl86T0uBsL0nq4tkbH3 12KNNwxnQ8o7l1UYUguTe3bIYJPL00vCqKoKSohf7NcLq0FBUEtp640Ngqgtz46+W2El TtJWuUO93NrnvYKiLlMmtpYWGRj1436rgDKXJEqS7+myDfdvgxP1DWvn/pYrFXTESAFh KzUw== X-Gm-Message-State: ALoCoQkTD6OJ3IqdrchpZmGAXX+Vq35kab3HA5Safqap5tjOf1ejQXbh3c988g2sEC4DkBFWwx8t X-Received: by 10.66.145.74 with SMTP id ss10mr25067946pab.28.1436394874486; Wed, 08 Jul 2015 15:34:34 -0700 (PDT) Received: from [10.64.26.63] ([69.53.236.236]) by smtp.gmail.com with ESMTPSA id k9sm3608281pdp.60.2015.07.08.15.34.32 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 08 Jul 2015 15:34:33 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r285284 - head/lib/liblzma Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Content-Type: multipart/signed; boundary="Apple-Mail=_F9AD8F9D-4C77-437A-B3CB-F29CB1CD24A4"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5 From: Warner Losh In-Reply-To: Date: Wed, 8 Jul 2015 16:34:31 -0600 Cc: Pedro Giffuni , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <1F6CFFCA-3901-4F18-AF30-EC621E5A4E06@bsdimp.com> References: <201507081836.t68IacJu069563@repo.freebsd.org> <559D9172.9040305@FreeBSD.org> <559DA2AE.2090202@FreeBSD.org> To: Adrian Chadd X-Mailer: Apple Mail (2.2102) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 22:34:35 -0000 --Apple-Mail=_F9AD8F9D-4C77-437A-B3CB-F29CB1CD24A4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I doubt it would ever be useful. For gcc, just test for 4.2.1. For clang, what specific feature do you need to test for? Do you have a specific use case in mind? This strikes me as a really bad idea absent some use case that has a = real example behind it. Warner > On Jul 8, 2015, at 4:28 PM, Adrian Chadd = wrote: >=20 > hi, >=20 > ok. would it be possible to add a blessed way to say "this is the > freebsd modified compiler in-tree" ? >=20 > I'd like to see / play around with more external-toolchain driven > building and using it for port bringups. >=20 > Thanks, >=20 >=20 > -adrian >=20 >=20 > On 8 July 2015 at 15:22, Pedro Giffuni wrote: >>=20 >>=20 >> On 07/08/15 17:04, Adrian Chadd wrote: >>>=20 >>> Is there a blessed way to see whether the compiler we're using is an >>> external compiler, or an internal one? >>=20 >>=20 >> No blessed way: you still have to determine the version of >> the external compiler for most purposes anyways. >> The internal compiler (even clang) always reports itself >> as gcc 4.2. >>=20 >>> eg, the version check isn't enough - it's just a number. how do I = know >>> if it's freebsd clang versus upstream clang? >>> (Or in my instance, freebsd-gcc versus upstream-gcc.) >>=20 >>=20 >> If the compiler reports itself as gcc >=3D 4.3 it is surely an >> external compiler. The tricky part is that our internal gcc >> supports some gcc 4.3 flags and Apple extensions >> (blocks), but those are not causing a problem AFAICT. >>=20 >> Pedro. >>=20 >>=20 >>>=20 >>> -a >>>=20 >>>=20 >>> On 8 July 2015 at 14:09, Pedro Giffuni wrote: >>>>=20 >>>>=20 >>>> On 07/08/15 13:36, Luigi Rizzo wrote: >>>>>=20 >>>>> Author: luigi >>>>> Date: Wed Jul 8 18:36:37 2015 >>>>> New Revision: 285284 >>>>> URL: https://svnweb.freebsd.org/changeset/base/285284 >>>>>=20 >>>>> Log: >>>>> only enable immintrin when clang is used. The base gcc does not >>>>> support >>>>> it. >>>>> Reviewed by: delphij >>>>>=20 >>>>> Modified: >>>>> head/lib/liblzma/config.h >>>>>=20 >>>>> Modified: head/lib/liblzma/config.h >>>>>=20 >>>>>=20 >>>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>>> --- head/lib/liblzma/config.h Wed Jul 8 18:12:24 2015 >>>>> (r285283) >>>>> +++ head/lib/liblzma/config.h Wed Jul 8 18:36:37 2015 >>>>> (r285284) >>>>> @@ -150,7 +150,8 @@ >>>>> #define HAVE_ICONV 1 >>>>> /* Define to 1 if you have the header file. */ >>>>> -#if defined(__FreeBSD__) && defined(__amd64__) >>>>> +/* FreeBSD - only with clang because the base gcc does not = support it >>>>> */ >>>>> +#if defined(__clang__) && defined(__FreeBSD__) && = defined(__amd64__) >>>>> #define HAVE_IMMINTRIN_H 1 >>>>> #endif >>>>>=20 >>>> FWIW, gcc 4.3+ does have it so this may some undesired (but hidden) >>>> effect when building with an external gcc. >>>>=20 >>>> Pedro. >>>>=20 >>=20 >=20 --Apple-Mail=_F9AD8F9D-4C77-437A-B3CB-F29CB1CD24A4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVnaV3AAoJEGwc0Sh9sBEAb2kQAOEg5QjkRG0yC3ggt5SgQ+us E9POokF1qOfyT7duO/OhFWiZX3vi4gP1aYTibdzP6MyqvQ1LA4vmQ3J0E6CF6VzK irpZGEyKNz1ZS1CpSjWAr2GyNn5lZ8mVsZibxF06+Z9E83f5pkqnxhy8QK2QRoTv yOVxhuAX2LGp+JB+kfVXaOQge3CUv/3+SyUzOA3MpGrrKVQ+UhZU7ZMD9qbLXU+4 fSqK9nXwUJP2+nXuw95ZLbKN5DOuLd2cSZQi+1Fgukdj3dZZv6Ll249641G3I0Vc Eltzi5IzuY3X33vm5Q8OTmTW8Dk9xd8i31C0dNNYkIcWvDyAlFdu6mPccFjbgB/L mrzDwNU7eICWny7Lm8pisCTmadEimhZMwgRgXctsGjGfJOXT9SBHW4ANwZzjBrmf 2bB74PcyXcws8bL6KJuq4cIDxjNoqU6prZ1nhhLUK4jlX1GqDyR6eANz80VIbvcf YalHOIGMv6kBg6+mfWs+t/DW1Q1XQiDlF6lG5ErK1nEhvq6dIT6HexwRxCAcgPzS jf4jqzfHtYvArtU1SWyqXHiloIxVi282+Ei15aYiRfq4fSUuItNz/EK1EEgpj0Mi Yx4+ZiKDx3nmcO9O96cOI+cKf1rduyztaX0e3+mnLDCTQbwJEUIcmtMGuUfzGLJ0 btWVlTqyltTBpSQEyDv6 =mxVg -----END PGP SIGNATURE----- --Apple-Mail=_F9AD8F9D-4C77-437A-B3CB-F29CB1CD24A4--