From owner-freebsd-current@FreeBSD.ORG Tue Dec 9 09:07:14 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A323B16A4CE for ; Tue, 9 Dec 2003 09:07:14 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id A59BD43D2C for ; Tue, 9 Dec 2003 09:07:11 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.10/8.12.9) with ESMTP id hB9H75Rm019297; Tue, 9 Dec 2003 09:07:05 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.10/8.12.10/Submit) id hB9H74Qj019296; Tue, 9 Dec 2003 09:07:04 -0800 (PST) (envelope-from obrien) Date: Tue, 9 Dec 2003 09:07:04 -0800 From: "David O'Brien" To: Clement Laforet Message-ID: <20031209170704.GA19222@dragon.nuxi.com> References: <20031209121900.GA4691@wedge.madpilot.net> <20031209132148.3ba7c176.sheepkiller@cultdeadsheep.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031209132148.3ba7c176.sheepkiller@cultdeadsheep.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-BETA Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: freebsd-current@freebsd.org cc: Guido Falsi Subject: Re: added Moxa multiserial board PCI id to puc(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Dec 2003 17:07:14 -0000 On Tue, Dec 09, 2003 at 01:21:48PM +0000, Clement Laforet wrote: > On Tue, 9 Dec 2003 13:19:00 +0100 > Guido Falsi wrote: > > > > Thank you again for the good work. Hope someone will give this a chance > > to get in the repository :) > > You will have better chance to get your patch committed is you send a PR ;-) Nope, he'd have a better chance getting the patch committed if it actually applied: foo:/sys/dev/puc> patch < /tmp/p Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- pucdata.c.orig Tue Dec 9 13:15:34 2003 |+++ pucdata.c Tue Dec 9 13:14:28 2003 -------------------------- Patching file pucdata.c using Plan A... Hunk #1 failed at 1015. 1 out of 1 hunks failed--saving rejects to pucdata.c.rej Hmm... Ignoring the trailing garbage. done the MUA stripped the tabs.