From nobody Tue Mar 31 15:59:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4flXqG3SZGz6WFCV for ; Tue, 31 Mar 2026 15:59:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4flXqF6XM2z3gyn for ; Tue, 31 Mar 2026 15:59:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774972745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SKvJ2BgdDPlYqp+ffE8geSncnfWgDSZ03J1t+DIQsyw=; b=DyROLOefI3IuJOWkEwyUvFLVBTds69Q2ZciHB7uPhBkpGW/KeAFgwkblROrAmzB/9k8r5q tq9oQboIPPHkW3PM6JZHYu/wyzd9BFXc2G1gveWCFPf0f8TWMhzKklGUycwgjyr2uTY67y a4Sm9S8J1qbcCQB6UouPFgI8KgZp8pfD93naDklGRqlsrhbTc/DB2z0Q6isS7jVKRCV3om +BuRJtXhEdklrfvX3tB3F8+uuHHicVpMkNimH/7nabnsPIQYbOP+00FKPylaQ+JLJkn2u8 uUObNEb1NcFysa6siJLd7NP72VrFm+wAwH9pTkizQ6YsoJB0Xb0nJcp2SDqeIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774972745; a=rsa-sha256; cv=none; b=mH0E4hR8eNJ693ud9AgV6z1A/jUi8RaH9ypltokk7oop7yjeHyqvw7rR6M7w6JzaZ6kFy4 Lwxm4uG0x7O2WByq6yuPo0nDZP3iLqu9Pn4MOMoUCxxW4bo5Xvnp2wfU2VQX3cHobOs28X SXKkOGxE21F98LL8xeHcwkfqglgBPrM9Fc2PJ9dH3p6ipBqXWzjVYbts0RgY036tMq8MgV 7Ji5GuDJnCNdAiGLx1sY+jpU0WPrsYE8a9gO7pnyZyuxs7gAEpOEh7y3gIrOFbRyZsF9IX ICz3hifN37h2weUKESfadBfjVHh3nile8YducDTWRbVuj8k2EvBuZjtBHjx6zg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774972745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SKvJ2BgdDPlYqp+ffE8geSncnfWgDSZ03J1t+DIQsyw=; b=Nd2rznZjn6zA3n647uZRXyRw7P8ScSJjnzvP97a8S0JrodlFzqlT514sXV32XGQrLdeLlz zc24MBUuWq8aG7QB9QUMCxVKTMl1DRpl+ZA8HT0Ew5XmilNSSDYd9QzkIKuZ7nqniFiIBM +Qa/O+oVT2loqs0NadEn+2P6fTzhCB1NytRSAUdHVcyzSi8UJLpMuop89FCdDnxGs7hvcJ eVdPLvx2NBn/OXE9342Wq3qpA1tBacWotG+t4wv/e98zxbFhw3QdtTsAKmvaStQpFoH+Ij sq3uCi0eum93VCyLd5kGyHcjwpbANg22tIa3hVnQxCV0Gzxji15LNKwU8LPdFQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4flXqF4FymzcNL for ; Tue, 31 Mar 2026 15:59:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 395f8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 31 Mar 2026 15:59:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 5f7525c0210c - stable/15 - pipe: Avoid unnecessary priv_check() calls in pipespace_new() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 5f7525c0210c9ef8e06b7b3c7e6049e356fad009 Auto-Submitted: auto-generated Date: Tue, 31 Mar 2026 15:59:05 +0000 Message-Id: <69cbef49.395f8.44cb96b1@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=5f7525c0210c9ef8e06b7b3c7e6049e356fad009 commit 5f7525c0210c9ef8e06b7b3c7e6049e356fad009 Author: Mark Johnston AuthorDate: 2026-02-21 16:28:49 +0000 Commit: Mark Johnston CommitDate: 2026-03-31 15:57:29 +0000 pipe: Avoid unnecessary priv_check() calls in pipespace_new() Running out of pipe map KVA is a rare case, so reorder checks accordingly, presuming that calling priv_check() is more expensive than the calculation. In particular, priv_check() might not be cheap to evaluate if MAC hooks are installed. Reviewed by: olce, kib MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D55378 (cherry picked from commit fa77660a3ccbd5f30e88093703b0f93892ef35d7) --- sys/kern/sys_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/sys_pipe.c b/sys/kern/sys_pipe.c index b319f0ac9c53..e5a49ef3a526 100644 --- a/sys/kern/sys_pipe.c +++ b/sys/kern/sys_pipe.c @@ -600,8 +600,8 @@ retry: } vm_map_lock(pipe_map); - if (priv_check(curthread, PRIV_PIPEBUF) != 0 && maxpipekva / 100 * - (100 - pipebuf_reserv) < amountpipekva + size) { + if (maxpipekva / 100 * (100 - pipebuf_reserv) < amountpipekva + size && + priv_check(curthread, PRIV_PIPEBUF) != 0) { vm_map_unlock(pipe_map); chgpipecnt(cpipe->pipe_pair->pp_owner->cr_ruidinfo, -size, 0); if (cpipe->pipe_buffer.buffer == NULL &&