From owner-freebsd-current@FreeBSD.ORG Fri Nov 17 19:12:41 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 909B216A407 for ; Fri, 17 Nov 2006 19:12:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05CF843D55 for ; Fri, 17 Nov 2006 19:12:40 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kAHJCakb051880; Fri, 17 Nov 2006 14:12:36 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-current@freebsd.org Date: Fri, 17 Nov 2006 13:17:14 -0500 User-Agent: KMail/1.9.1 References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611171317.14909.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 17 Nov 2006 14:12:36 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2201/Fri Nov 17 07:16:33 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Mark Atkinson Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2006 19:12:41 -0000 On Friday 17 November 2006 12:22, Mark Atkinson wrote: > (moving to current to avoid dirtying src further) > > John Baldwin wrote: > > jhb 2006-11-15 20:04:57 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bce if_bce.c > > sys/dev/em if_em.c if_em.h > > sys/dev/mpt mpt.h mpt_pci.c > > Log: > > Add MSI support to em(4), bce(4), and mpt(4). For now, we only support > > devices that support a maximum of 1 message, and we use that 1 message > > instead of the INTx rid 0 IRQ with the same interrupt handler, etc. > > > > Revision Changes Path > > 1.19 +11 -3 src/sys/dev/bce/if_bce.c > > 1.164 +11 -2 src/sys/dev/em/if_em.c > > 1.56 +1 -0 src/sys/dev/em/if_em.h > > 1.31 +1 -0 src/sys/dev/mpt/mpt.h > > 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c > > _______________________________________________ > > cvs-src@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/cvs-src > > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > > This is great, I don't know if you plan on adding MSI support to all network > drivers that could support it, but here's the output from the Tyan S2895 > (k8WE) for the nve0 and nve1 devices, which report supporting 2 messages. > > pcib0: matched entry for 0.10.INTA (src \\_SB_.PCI0.LMAC:0) > pci_link8: Picked IRQ 21 with weight 1 > pcib0: slot 10 INTA routed to irq 21 via \\_SB_.PCI0.LMAC > found-> vendor=0x10de, dev=0x005d, revid=0xa3 > bus=0, slot=14, func=0 > class=06-04-00, hdrtype=0x01, mfdev=0 > cmdreg=0x0107, statreg=0x0010, cachelnsz=16 (dwords) > lattimer=0x00 (0 ns), mingnt=0x0c (3000 ns), maxlat=0x00 (0 ns) > powerspec 2 supports D0 D3 current D0 > MSI supports 2 messages, 64 bit > > [...] > > pcib6: matched entry for 128.10.INTA (src \\_SB_.PCI1.LMAC:0) > pci_link22: Picked IRQ 52 with weight 0 > ioapic3: Changing polarity for pin 20 to high > pcib6: slot 10 INTA routed to irq 52 via \\_SB_.PCI1.LMAC > found-> vendor=0x10de, dev=0x005d, revid=0xa3 > bus=128, slot=14, func=0 > class=06-04-00, hdrtype=0x01, mfdev=0 > cmdreg=0x0107, statreg=0x0010, cachelnsz=16 (dwords) > lattimer=0x00 (0 ns), mingnt=0x04 (1000 ns), maxlat=0x00 (0 ns) > powerspec 2 supports D0 D3 current D0 > MSI supports 2 messages, 64 bit > > nve0@pci0:10:0: class=0x068000 card=0x289510f1 chip=0x005710de rev=0xa3 > hdr=0x00 > vendor = 'NVIDIA Corporation' > device = 'nForce4 Ethernet Controller' > class = bridge > > nve1@pci128:10:0: class=0x068000 card=0x289510f1 chip=0x005710de rev=0xa3 > hdr=0x00 > vendor = 'NVIDIA Corporation' > device = 'nForce4 Ethernet Controller' > class = bridge For devices that support more than 1 message you really need docs to figure out what conditions the different messages are tied to (and if it will work if the system only gives it 1 message instead of 2, etc.) -- John Baldwin