From owner-freebsd-acpi@FreeBSD.ORG Thu Feb 19 12:00:47 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6933C1065679 for ; Thu, 19 Feb 2009 12:00:47 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.158]) by mx1.freebsd.org (Postfix) with ESMTP id DDE5F8FC23 for ; Thu, 19 Feb 2009 12:00:46 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by fg-out-1718.google.com with SMTP id l26so962289fgb.35 for ; Thu, 19 Feb 2009 04:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-pgp-agent:x-mailer; bh=DryFGHP71DkWi5nDbWIF/islM8BH4K4Z+aqCCmzx24Q=; b=DjCU46Fa2/rQFflkAUvVuYtIARDEkeLalY5NEJKdn6o3dYtIIfemSSLnwsarB9Mm7f fN28ptSH5d8zI+oCN32qjS29jUJ5XOtrmv559XOZyV7vNhcm7taPF+4M4BKcA/YWan3x IpNZM8O7N5a4xlKZLz4nXVQbp+jChnJJt2igA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-pgp-agent:x-mailer; b=ooJImvy6/mFKEmlEkRW7trk9JX65Zmc57ylReN6drGSRPqjYIRj12oPMjukN84w/cw YkYLCwOn+gVFXPo4DDxXqleCP3kxd5t7AODUTC59BtS+ssGh9sBVq4Ew9qqJz8GQhatr t3XU6NX53FvqHU30jGdl48WzlYgdOBcVW+Fgs= Received: by 10.103.93.18 with SMTP id v18mr386280mul.43.1235044845805; Thu, 19 Feb 2009 04:00:45 -0800 (PST) Received: from epsilon.lan (bl6-150-39.dsl.telepac.pt [82.155.150.39]) by mx.google.com with ESMTPS id e23sm3102333ugd.54.2009.02.19.04.00.44 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 19 Feb 2009 04:00:45 -0800 (PST) Sender: Rui Paulo Message-Id: <024CB687-4C71-4B57-A105-E4F0BA0DEF32@FreeBSD.org> From: Rui Paulo To: Andriy Gapon In-Reply-To: <499D3E2E.7090500@icyb.net.ua> Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-1--960399079" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Date: Thu, 19 Feb 2009 12:00:38 +0000 References: <498708FD.9030404@icyb.net.ua> <66885316-6F5B-4C56-BFE0-DBB86E050C99@freebsd.org> <499D3E2E.7090500@icyb.net.ua> X-Pgp-Agent: GPGMail 1.2.0 (v56) X-Mailer: Apple Mail (2.930.3) Cc: freebsd-acpi@FreeBSD.org Subject: Re: piix4 and C2: patch for BRLD_EN_BM/ACPI_BITREG_BUS_MASTER_RLD X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2009 12:00:48 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-1--960399079 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit On 19 Feb 2009, at 11:10, Andriy Gapon wrote: > on 02/02/2009 17:50 Rui Paulo said the following: >> >> On 2 Feb 2009, at 14:53, Andriy Gapon wrote: >> >>> >>> Another patch for acpi_cpu code related to PIIX4 chipset. >>> >>> We do not support C3 with this chipset and as such we never touch >>> ACPI_BITREG_BUS_MASTER_RLD when running on it. It's also possible >>> (probable) that we never reset ACPI_BITREG_BUS_MASTER_STATUS >>> (because of >>> CPU_QUIRK_NO_BM_CTRL). >>> So, if BIOS configures ACPI_BITREG_BUS_MASTER_RLD to 1 and >>> ACPI_BITREG_BUS_MASTER_STATUS gets set to 1, we would get a >>> situation >>> where the system would always immediately break out of C2 state >>> should >>> we ever attempt to enter it. >>> >>> Actually, ACPI spec says that bus master activity need not break >>> out of >>> C2 state (only interrupts must do that). >>> >>> Given all of the above, it seems to be safe and desired to reset >>> ACPI_BITREG_BUS_MASTER_RLD to zero with this chipset. >>> >>> The patch is successfully tested on a real system that exhibited the >>> above behavior (immediate backout from cx_lowest of C2 to C1). >> >> >> >> Looks ok to me. I no longer have a PIIX4 system to test it, though. >> So, >> if no one raises any objection, I'll commit it to HEAD in a few days. >> >> Andriy, if I forget, please ping me :-) > > Rui, > > may I commit this one now? :) If it builds correctly, yes. Please add Reviewed by: rpaulo (mentor), njl Regards, -- Rui Paulo --Apple-Mail-1--960399079 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAkmdSeYACgkQfD8M/ASTygLa7QCdFNn3x11SCFI2JNUqM/JcSJpr GbQAn3dKCgTWYr4ylqXi3dGV7VeNW4Yl =ITCf -----END PGP SIGNATURE----- --Apple-Mail-1--960399079--