From owner-cvs-all Wed Jan 16 17: 4:51 2002 Delivered-To: cvs-all@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id DDE9A37B405 for ; Wed, 16 Jan 2002 17:04:40 -0800 (PST) Received: (qmail 26355 invoked from network); 17 Jan 2002 01:04:40 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 17 Jan 2002 01:04:40 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020116162418.P26067@elvis.mu.org> Date: Wed, 16 Jan 2002 17:03:57 -0800 (PST) From: John Baldwin To: Alfred Perlstein Subject: Re: cvs commit: src/sys/kern sys_generic.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 17-Jan-02 Alfred Perlstein wrote: > * John Baldwin [020116 16:01] wrote: >> >> On 16-Jan-02 Alfred Perlstein wrote: >> > alfred 2002/01/16 13:33:41 PST >> > >> > Modified files: >> > sys/kern sys_generic.c >> > Log: >> > Fix giant handling in pwrite(2), I forgot to release it when finishing >> > the syscall. >> >> Uh, this isn't correct. fdrop() can call fo_close() can call down into VFS >> and do a vrele(), so fdrop() still needs Giant. If you aren't holding Giant >> across fdrop() in a few places that might explain the vput(0x0) panics. > > Ugh, I'll get to this tonight unless you want to tackle it now. No, I'm moving across the country for the next week or so starting tomorrow and wouldn't have time to do it much less test it. > -Alfred -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message