Date: Sun, 6 Feb 2000 21:44:50 -0500 (EST) From: karpes@rpi.edu To: FreeBSD-gnats-submit@freebsd.org Subject: ports/16541: [FIX INCLUDED] ports/print/klyx fails to compile on -CURRENT Message-ID: <200002070244.VAA46128@karpes.stu.rpi.edu>
next in thread | raw e-mail | index | archive | help
>Number: 16541
>Category: ports
>Synopsis: ports/print/klyx fails to compile on -CURRENT
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Feb 6 18:50:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator: Simon Karpen
>Release: FreeBSD 4.0-CURRENT i386
>Organization:
RPI
>Environment:
4.0-CURRENT, cvsup as of 2/5/2000, all ports built from very
recent ports tree. Ports tree cvsup'd about an hour ago.
>Description:
There is a C++ error in one of klyx's headers. The compiler error is below.
c++ -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/local/include -I/usr/X11R6/include/X11/qt -I/usr/X11R6/include -I../images -O -pipe -c LyXView.C
LyXView.C:1112: warning: #warning Make this work with all URLs when file loading is switched to kfm
In file included from LyXView.C:53:
SendFaxDialog.h:26: ANSI C++ forbids declaration `setFilename' with no type
SendFaxDialog.h:27: ANSI C++ forbids declaration `setSendCmd' with no type
SendFaxDialog.h:28: ANSI C++ forbids declaration `setPhone' with no type
SendFaxDialog.h:29: ANSI C++ forbids declaration `setName' with no type
SendFaxDialog.h:30: ANSI C++ forbids declaration `setCompany' with no type
gmake[2]: *** [LyXView.o] Error 1
gmake[2]: Leaving directory `/usr/ports/print/klyx/work/klyx-0.10.0/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/print/klyx/work/klyx-0.10.0'
gmake: *** [all-recursive-am] Error 2
*** Error code 2
>How-To-Repeat:
cd /usr/ports/print/klyx
make
>Fix:
The functions without proper return type declarations are all
void functions, as they don't return anything. ANSI C++ does not
implicitly make a function void if no return type is specified.
The patch below corrects the problem and allows klyx to build
normally.
--- SendFaxDialog.h~ Sun Mar 15 02:11:19 1998
+++ SendFaxDialog.h Sun Feb 6 21:33:15 2000
@@ -23,11 +23,11 @@
SendFaxDialog ( LyXView* view, QWidget * parent=0, const char * name=0,
WFlags f=0 );
- setFilename( QString _filename ) { filename = _filename; }
- setSendCmd( QString _sendcmd ) { sendcmd = _sendcmd; }
- setPhone( QString _phone ) { faxnoED->setText( _phone ); }
- setName( QString _name ) { destnameED->setText( _name ); }
- setCompany( QString _name ) { companyED->setText( _name ); }
+ void setFilename( QString _filename ) { filename = _filename; }
+ void setSendCmd( QString _sendcmd ) { sendcmd = _sendcmd; }
+ void setPhone( QString _phone ) { faxnoED->setText( _phone ); }
+ void setName( QString _name ) { destnameED->setText( _name ); }
+ void setCompany( QString _name ) { companyED->setText( _name ); }
private slots:
void okClicked();
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200002070244.VAA46128>