From owner-freebsd-hackers@freebsd.org Wed Dec 13 19:12:20 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9758E83D2A for ; Wed, 13 Dec 2017 19:12:20 +0000 (UTC) (envelope-from mmcco@mykolab.com) Received: from mx.kolabnow.com (mx.kolabnow.com [95.128.36.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6B3B87EA7E for ; Wed, 13 Dec 2017 19:12:20 +0000 (UTC) (envelope-from mmcco@mykolab.com) Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id 2AF77108E for ; Wed, 13 Dec 2017 20:02:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mykolab.com; h= content-disposition:content-type:content-type:mime-version :message-id:subject:subject:from:from:date:date:received :received:received; s=dkim20160331; t=1513191754; x=1513191776; bh=XAaIHd08JM53wlkjmReqHBbYh/2xQqKsxsPMraD7qUo=; b=0RdEDhxezhZw PejK4l2fnUpiL8z9TCoCXnk+dPJAiIl/CwAjWIqlCf+b556v1YtqGIDCfbNT8N3n 4BtP/49tw9c+NjR9Yik+r2QQuLtB54OmaLssPplhDwoHR4I9w8PlFtE9zK1CVqaX HJ2DB+f3Z5AacpjoP4mi0DPayTNvJatjn6vMlFDFiTk7mr+CejTLYei5G0fYLvA5 EiFgP37LsD0GtDf2U+/so+rPTGIaK1qDEFOcDtBdRk96R3dWs9KTdcEG5D70uRal z0pBijt19NB1FSxMmSnnq5gSiphKtXq1mGBlorfMjjfqeSue/5BnlDWBtTH9F055 CChTw5dxzegnlJe5YBbUesvIKqXFmZhKlJhma7wrxnyB5E7ayOMt+5rqUpsblfBL zzSfIb3XSsc0saNnVcDGgpOI7DAJKntx1nk6QD2RiC7BFkEYcZKkhsl0lbKNH+3c 1KjIraK5raFnH3DrFpkK78r4z92w/c2ikM3j8fxOnZtVPmGh4IX1+j52WbkDcgd1 t49oYvoptwyZYuXuY9FwBuKJ9ckh+pNWyhUJ2IJCFSFli9GnfVKjZAUoBYx4vWHc 3tECZVq2eC+MGDlp2fGDT1C+QfKQ3CPeH3bWMeJJLy9bpgIZRrcT3pZH1epSFm5+ GmWmm5hih9GehrvleUgg7QDfgGLLQfE= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -0.871 X-Spam-Level: X-Spam-Status: No, score=-0.871 tagged_above=-10 required=4.5 tests=[ALL_TRUSTED=-1, AWL=0.128, FREEMAIL_FROM=0.001] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hMHIsw_7kwAU for ; Wed, 13 Dec 2017 20:02:34 +0100 (CET) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id C66157A8 for ; Wed, 13 Dec 2017 20:02:34 +0100 (CET) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx002.mykolab.com (Postfix) with ESMTPS id AC4E4234A for ; Wed, 13 Dec 2017 20:02:34 +0100 (CET) Date: Wed, 13 Dec 2017 12:02:31 -0700 From: Michael McConville To: freebsd-hackers@freebsd.org Subject: Possibly misordered arguments to memset(3) Message-ID: <20171213190230.gf5gax7vswakgrd4@t240> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 19:12:20 -0000 I can't claim to understand this function, but it seems unlikely that the current ordering of the arguments was intentional. Thanks for your time, Michael McConville University of Utah diff --git a/tools/tools/netmap/pkt-gen.c b/tools/tools/netmap/pkt-gen.c index 168e022cfba..6946ac3ba0e 100644 --- a/tools/tools/netmap/pkt-gen.c +++ b/tools/tools/netmap/pkt-gen.c @@ -612,7 +612,7 @@ dump_payload(const char *_p, int len, struct netmap_ring *ring, int cur) ring->slot[cur].flags, len); /* hexdump routine */ for (i = 0; i < len; ) { - memset(buf, sizeof(buf), ' '); + memset(buf, ' ', sizeof(buf)); sprintf(buf, "%5d: ", i); i0 = i; for (j=0; j < 16 && i < len; i++, j++)