From owner-cvs-src Thu Mar 6 10: 1:36 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 142BA37B401 for ; Thu, 6 Mar 2003 10:01:34 -0800 (PST) Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35B1A43FD7 for ; Thu, 6 Mar 2003 10:01:31 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 30885 invoked from network); 6 Mar 2003 18:01:34 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail13.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 6 Mar 2003 18:01:34 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id h26HwchT052159; Thu, 6 Mar 2003 12:58:39 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200303061725.h26HP66f033827@repoman.freebsd.org> Date: Thu, 06 Mar 2003 13:01:43 -0500 (EST) From: John Baldwin To: John Baldwin Subject: RE: cvs commit: src/sys/kern subr_witness.c Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 06-Mar-2003 John Baldwin wrote: > jhb 2003/03/06 09:25:06 PST > > FreeBSD src repository > > Modified files: > sys/kern subr_witness.c > Log: > Oops, fix the double faults people were seeing with the recent changes to > witness. Sleepable locks such as sx locks always come before all mutexes > including Giant. However, the static lock order list placed Giant before > the proctree and allproc sx locks. This resulted in witness creating a > cycle in its lock order "tree" (real trees don't have cycles) leading to > infinite recursion and eventually a double fault. To fix, put Giant after > sx locks in the lock order list. > > Revision Changes Path > 1.141 +1 -1 src/sys/kern/subr_witness.c Should have added: Thanks to jlemon for a full backtrace with some helpful symbols. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message