From owner-svn-src-head@freebsd.org Fri Apr 14 11:52:48 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5110AD3C24D for ; Fri, 14 Apr 2017 11:52:48 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yw0-x22b.google.com (mail-yw0-x22b.google.com [IPv6:2607:f8b0:4002:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1A709F9 for ; Fri, 14 Apr 2017 11:52:47 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yw0-x22b.google.com with SMTP id l189so34882789ywb.0 for ; Fri, 14 Apr 2017 04:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VwYDLFPpsVaKzUuZyRVhhej9gYF68lHZQ2JrSR2w3gE=; b=bCs4rk2CMJqDEJLueXyPBvAV3PwSo3MFBm9XgZRLcB/0NN7XwfLHxt3oi0dD6oZX5l 5RJrl0bOxErO+nF2eBaqd0jcYnqvjoL1WJc/xC0NG1oHU0cykUvKCJIE4hOMay/2sSvp MY8jtKiJrN8V+6ivQwAm5qcJ1zH58L+wOhcJjWXJ4weRexm/neaj2HlwVyzUuwwxsJOd lf2W9rhPv4k765BwqR6CWJCY4D4hVIpvFWi3iBCTOQ3Kc9wTNtZdc9a6lmXE3sxvtidT No1cswCHl79qkqUwT+AyVryb3x+MoKCKaeBvJM9OModU84T9HvA9KeDxtXZ9s14asLdW dvYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VwYDLFPpsVaKzUuZyRVhhej9gYF68lHZQ2JrSR2w3gE=; b=Se4L0776NEXYkEEv36XnSeG2LKNeLcOcIrXF0XAMBl0U+Z0bIahAFK9XXvDe2b9oC5 AUQmlGIyVkbbvezOMoSGTNnlIsNbd96hgn+7ZT0h9cl4l3TPHpPm1K9+MBXMU6ZVMvnD RTgeP2dLKcO99nElGRYEOsu0qN9Gsi54/jkBk+OdUEpyBDiIc1oN1m13YOdQ40Zue97Y uzfCytqIlDt05mvXadwn1ErBGu1ICo7jVJtxpiO/7GAgsWnoHV6Z76xhVXN1Pdx/ZNV5 7889uPCP4m0rzDQG2t36FMVloYu6B5CNrpiafM0jz35NfjZ94O+jq8d7JMdDMW43YJy7 tJaA== X-Gm-Message-State: AN3rC/5VqXEcgEq5L5PdwhWl23eUUpU89jiapjkR1rO5Xns7RujdByCz 5KQLXkPWPNwbUu+stj4e73RvgPEP0w== X-Received: by 10.129.93.214 with SMTP id r205mr5669459ywb.95.1492170766731; Fri, 14 Apr 2017 04:52:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.105.198 with HTTP; Fri, 14 Apr 2017 04:52:16 -0700 (PDT) In-Reply-To: <201704141141.v3EBf9MC097085@repo.freebsd.org> References: <201704141141.v3EBf9MC097085@repo.freebsd.org> From: Ed Schouten Date: Fri, 14 Apr 2017 13:52:16 +0200 Message-ID: Subject: Re: svn commit: r316825 - head/sys/netpfil/ipfw To: "Andrey V. Elsukov" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 11:52:48 -0000 Hi there, 2017-04-14 13:41 GMT+02:00 Andrey V. Elsukov : > - memcpy(&tent->k, &xn->addr6.sin6_addr, sizeof(struct in6_addr)); > + memcpy(&tent->k.addr6, &xn->addr6.sin6_addr, > + sizeof(struct in6_addr)); In this case the code could be abbreviated by simply using assignment, right? tent->k.addr6 = xn->addr6.sin6_addr; -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717