From owner-freebsd-fs@FreeBSD.ORG Fri Jul 5 10:38:00 2013 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id DA1F4113 for ; Fri, 5 Jul 2013 10:38:00 +0000 (UTC) (envelope-from daniel@digsys.bg) Received: from smtp-sofia.digsys.bg (smtp-sofia.digsys.bg [193.68.21.123]) by mx1.freebsd.org (Postfix) with ESMTP id 5CBAB1182 for ; Fri, 5 Jul 2013 10:38:00 +0000 (UTC) Received: from dcave.digsys.bg (dcave.digsys.bg [193.68.6.1]) (authenticated bits=0) by smtp-sofia.digsys.bg (8.14.6/8.14.6) with ESMTP id r65AbwfO025971 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Fri, 5 Jul 2013 13:37:59 +0300 (EEST) (envelope-from daniel@digsys.bg) Message-ID: <51D6A206.2020303@digsys.bg> Date: Fri, 05 Jul 2013 13:37:58 +0300 From: Daniel Kalchev User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130627 Thunderbird/17.0.7 MIME-Version: 1.0 To: freebsd-fs@freebsd.org Subject: Re: Slow resilvering with mirrored ZIL References: <51D42107.1050107@digsys.bg><2EF46A8C-6908-4160-BF99-EC610B3EA771@alumni.chalmers.se><51D437E2.4060101@digsys.bg><20130704000405.GA75529@icarus.home.lan><20130704171637.GA94539@icarus.home.lan><2A261BEA-4452-4F6A-8EFB-90A54D79CBB9@alumni.chalmers.se><20130704191203.GA95642@icarus.home.lan><43015E9015084CA6BAC6978F39D22E8B@multiplay.co.uk> <3CFB4564D8EB4A6A9BCE2AFCC5B6E400@multiplay.co.uk> In-Reply-To: <3CFB4564D8EB4A6A9BCE2AFCC5B6E400@multiplay.co.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jul 2013 10:38:00 -0000 On 05.07.13 02:28, Steven Hartland wrote: > > > If anyone wants my current patches which add switch to 4k ashift by > default > as a sysctl + works with QUIRKS too, just let me know. > > They are well tested, just we want more options before putting in the > tree. Is it not easier to add this as an option to zpool create, instead of an sysctl? That is, I believe we have two scenarios here: 1. Having an sysctl that instructs ZFS to look at the FreeBSD quirks to decide what the ashift should be, instead of only querying the 'sectorsize' property of the storage. I believe we might not even need an sysctl here, just make it default to obey the quirks --- but sysctl for the interim period will not hurt (with the proper default). 2. Have an option to zpool create and zpool add, that specifies the ashift value. Here my thinking is that it should let you specify an ashift equal or larger than the computed one, which is based on the largest sector size of all devices in a vdev. Don't know, but always wondered.. how hard is it to change the ashift value on the fly? Does it impact reads of data already on the vdev, or does it impact only writes? If only writes, it should be trivial, really.... Daniel