Date: Tue, 19 Sep 2000 17:21:54 +0100 From: Ben Smithurst <ben@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: doc@FreeBSD.org, ports@FreeBSD.org Subject: Re: Porter's Handbook patch Message-ID: <20000919172154.B30774@strontium.scientia.demon.co.uk> In-Reply-To: <39C77CA9.8AED84CA@FreeBSD.org> References: <39C77CA9.8AED84CA@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Sobolev wrote: > Please review attached patch, which intended to replace outdated First, you need two spaces after a fullstop. One space is Wrong[tm]. (Of course, if a sentence ends at the end of a line, the existing newline is just as good.) > + <para>If your port installs a shared library(ies), define a I think "If your port installs one or more shared libraries, ..." would sound better. That "library(ies)" looks ugly to me. > + shared library cache. Also this variable, when defined, will > + facilitate addition a appropriate I don't like that much. I'd prefer this: This variable, when defined, will also facilitate addition of an appropriate [...] > + make variable, which should contain list of directories into which s/contain list/contain a list/ > + through sed just like the rest of <filename>pkg/PLIST</filename>, "&man.sed.1;" instead of plain "sed", please. Other than that, it looks good to me. -- Ben Smithurst / ben@FreeBSD.org / PGP: 0x99392F7D To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000919172154.B30774>