From owner-svn-src-all@FreeBSD.ORG Tue Feb 4 21:23:13 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2E3BA468; Tue, 4 Feb 2014 21:23:13 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 178A61CC9; Tue, 4 Feb 2014 21:23:13 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s14LNCOu065748; Tue, 4 Feb 2014 21:23:12 GMT (envelope-from rmh@svn.freebsd.org) Received: (from rmh@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s14LNCtP065746; Tue, 4 Feb 2014 21:23:12 GMT (envelope-from rmh@svn.freebsd.org) Message-Id: <201402042123.s14LNCtP065746@svn.freebsd.org> From: Robert Millan Date: Tue, 4 Feb 2014 21:23:12 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r261497 - head/sys/dev/drm2/radeon X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Feb 2014 21:23:13 -0000 Author: rmh Date: Tue Feb 4 21:23:12 2014 New Revision: 261497 URL: http://svnweb.freebsd.org/changeset/base/261497 Log: Abort when firmware isn't present in R600+ models. More details at: http://anonscm.debian.org/viewvc/kernel/dists/trunk/linux/debian/patches/bugfix/all/radeon-firmware-is-required-for-drm-and-kms-on-r600-onward.patch?revision=20909&view=co Reviewed by: dumbbell MFC after: 1 week Modified: head/sys/dev/drm2/radeon/r600.c head/sys/dev/drm2/radeon/rv770.c Modified: head/sys/dev/drm2/radeon/r600.c ============================================================================== --- head/sys/dev/drm2/radeon/r600.c Tue Feb 4 21:15:15 2014 (r261496) +++ head/sys/dev/drm2/radeon/r600.c Tue Feb 4 21:23:12 2014 (r261497) @@ -3012,6 +3012,12 @@ int r600_init(struct radeon_device *rdev rdev->accel_working = false; } + /* Don't start up if the ucode is missing. */ + if (!rdev->me_fw || !rdev->pfp_fw || !rdev->rlc_fw) { + DRM_ERROR("radeon: ucode required for R600+.\n"); + return -EINVAL; + } + return 0; } Modified: head/sys/dev/drm2/radeon/rv770.c ============================================================================== --- head/sys/dev/drm2/radeon/rv770.c Tue Feb 4 21:15:15 2014 (r261496) +++ head/sys/dev/drm2/radeon/rv770.c Tue Feb 4 21:23:12 2014 (r261497) @@ -1186,6 +1186,12 @@ int rv770_init(struct radeon_device *rde rdev->accel_working = false; } + /* Don't start up if the ucode is missing. */ + if (!rdev->me_fw || !rdev->pfp_fw || !rdev->rlc_fw) { + DRM_ERROR("radeon: ucode required for R600+.\n"); + return -EINVAL; + } + return 0; }