From owner-freebsd-pf@FreeBSD.ORG  Fri Mar 19 13:40:04 2010
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
Delivered-To: freebsd-pf@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 842D61065672
	for <freebsd-pf@hub.freebsd.org>; Fri, 19 Mar 2010 13:40:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 589438FC18
	for <freebsd-pf@hub.freebsd.org>; Fri, 19 Mar 2010 13:40:04 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2JDe3qg017604
	for <freebsd-pf@freefall.freebsd.org>; Fri, 19 Mar 2010 13:40:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2JDe3o8017603;
	Fri, 19 Mar 2010 13:40:03 GMT (envelope-from gnats)
Date: Fri, 19 Mar 2010 13:40:03 GMT
Message-Id: <201003191340.o2JDe3o8017603@freefall.freebsd.org>
To: freebsd-pf@FreeBSD.org
From: Max Laier <max@love2party.net>
Cc: 
Subject: Re: kern/144311: [pf] [icmp] massive ICMP storm on lo0 occurs when
	using pf(4) 'reply-to'
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Max Laier <max@love2party.net>
List-Id: "Technical discussion and general questions about packet filter
	\(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Mar 2010 13:40:04 -0000

The following reply was made to PR kern/144311; it has been noted by GNATS.

From: Max Laier <max@love2party.net>
To: bug-followup@freebsd.org,
 kasahara@nc.kyushu-u.ac.jp
Cc: Pyun YongHyeon <pyunyh@gmail.com>
Subject: Re: kern/144311: [pf] [icmp] massive ICMP storm on lo0 occurs when using pf(4) 'reply-to'
Date: Fri, 19 Mar 2010 14:35:05 +0100

 --Boundary-00=_J23oL/ZH/GBB7xo
 Content-Type: Text/Plain;
   charset="us-ascii"
 Content-Transfer-Encoding: 7bit
 
 Can you please test the attached patch (by Pyun YongHyeon) and let us know if 
 this fixes the situation for you?
 
 Thanks,
   Max Laier
 
 --Boundary-00=_J23oL/ZH/GBB7xo
 Content-Type: text/x-patch;
   charset="ISO-8859-1";
   name="pf.routeto.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename="pf.routeto.patch"
 
 Index: sys/contrib/pf/net/pf.c
 ===================================================================
 --- sys/contrib/pf/net/pf.c	(revision 203960)
 +++ sys/contrib/pf/net/pf.c	(working copy)
 @@ -6375,6 +6375,7 @@
  	m0->m_pkthdr.csum_flags &= ifp->if_hwassist;
  
  	if (ntohs(ip->ip_len) <= ifp->if_mtu ||
 +	    (m0->m_pkthdr.csum_flags & ifp->if_hwassist & CSUM_TSO) != 0 ||
  	    (ifp->if_hwassist & CSUM_FRAGMENT &&
  		((ip->ip_off & htons(IP_DF)) == 0))) {
  		/*
 @@ -6449,7 +6450,7 @@
  	 * Too large for interface; fragment if possible.
  	 * Must be able to put at least 8 bytes per fragment.
  	 */
 -	if (ip->ip_off & htons(IP_DF)) {
 +	if (ip->ip_off & htons(IP_DF) || (m0->m_pkthdr.csum_flags & CSUM_TSO)) {
  		KMOD_IPSTAT_INC(ips_cantfrag);
  		if (r->rt != PF_DUPTO) {
  #ifdef __FreeBSD__
 
 --Boundary-00=_J23oL/ZH/GBB7xo--