From owner-svn-src-all@freebsd.org Tue Nov 21 17:39:49 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25FADDF50DE for ; Tue, 21 Nov 2017 17:39:49 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 08DB277872 for ; Tue, 21 Nov 2017 17:39:48 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: c25a59d2-cee2-11e7-b1c3-712f93d8ba90 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id c25a59d2-cee2-11e7-b1c3-712f93d8ba90; Tue, 21 Nov 2017 17:38:18 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id vALHceAI001122; Tue, 21 Nov 2017 10:38:40 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1511285920.13854.6.camel@freebsd.org> Subject: Re: svn commit: r326066 - in head/sys: arm64/conf conf dev/efidev modules/efirt From: Ian Lepore To: Andrew Turner , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 21 Nov 2017 10:38:40 -0700 In-Reply-To: <201711211723.vALHNGb6079662@repo.freebsd.org> References: <201711211723.vALHNGb6079662@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 17:39:49 -0000 On Tue, 2017-11-21 at 17:23 +0000, Andrew Turner wrote: > Author: andrew > Date: Tue Nov 21 17:23:16 2017 > New Revision: 326066 > URL: https://svnweb.freebsd.org/changeset/base/326066 > > Log: >   Add a driver for the EFI RTC. This uses the EFI Runtime Services to query >   the system time. >    >   As we seem to only read this time on boot, and this is the only source of >   time on many arm64 machines we need to enable this by default there. As >   this is not always the case with U-Boot firmware, or when we have been >   booted from a non-UEFI environment we only enable the device driver when >   the Runtime Services are present and reading the time doesn't result in an >   error. If the efi runtime returns an error for the case where time is invalid because the clock oscillator is stopped, this "don't attach on error" logic will result in the clock never working, because it is typically the act of writing a valid time to the device that starts the oscillator and clears the error condition. It might make sense to always attach the device, but only report an error in clock_settime() once. -- Ian